Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the
implementation for H2 and QUIC separately.

This is a part of the effort to expose timing metrics to net
embedders.

BUG=648346
Committed: https://crrev.com/ba8de43245cf4da038b3a178b6908ad2404466be
Cr-Commit-Position: refs/heads/master@{#419864}

[xunjieli, 2016-09-19 19:17:30]

xunjieli@chromium.org changed reviewers:
+ mef@chromium.org

[xunjieli, 2016-09-19 19:17:31]

Hi Misha, this CL is to add a virtual function. I will mail out the
implementation CLs separately to keep the change small. Thanks!

[xunjieli, 2016-09-19 19:26:50]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:26:53]

Dry run: This issue passed the CQ dry run.

[xunjieli, 2016-09-20 14:19:14]

Description was changed from

==========
Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the implementation
for SPDY and QUIC separately.

BUG=648346
==========

to

==========
Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the 
implementation for H2 and QUIC separately.

This is a part of the effort to expose timing metrics to net
embedders.

BUG=648346
==========

[xunjieli, 2016-09-20 17:24:08]

On 2016/09/19 19:17:31, xunjieli wrote:
> Hi Misha, this CL is to add a virtual function. I will mail out the
> implementation CLs separately to keep the change small. Thanks!

A friendly ping?
The SPDY and QUIC implementations have been l-g-t-m-ed.
https://codereview.chromium.org/2356463002/
https://codereview.chromium.org/2354653003/

Thanks!

[mef, 2016-09-20 20:37:50]

lgtm

https://codereview.chromium.org/2349363002/diff/1/net/http/bidirectional_stre...
File net/http/bidirectional_stream_impl.h (right):

https://codereview.chromium.org/2349363002/diff/1/net/http/bidirectional_stre...
net/http/bidirectional_stream_impl.h:155: // socket reuse info.
Could you document return value? What does return true vs false mean?

[xunjieli, 2016-09-20 20:43:53]

Thanks!

https://codereview.chromium.org/2349363002/diff/1/net/http/bidirectional_stre...
File net/http/bidirectional_stream_impl.h (right):

https://codereview.chromium.org/2349363002/diff/1/net/http/bidirectional_stre...
net/http/bidirectional_stream_impl.h:155: // socket reuse info.
On 2016/09/20 20:37:49, mef wrote:
> Could you document return value? What does return true vs false mean?

Done.

[xunjieli, 2016-09-20 20:44:03]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-09-20 20:44:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2349363002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-20 20:44:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:58:15]

Description was changed from

==========
Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the 
implementation for H2 and QUIC separately.

This is a part of the effort to expose timing metrics to net
embedders.

BUG=648346
==========

to

==========
Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the 
implementation for H2 and QUIC separately.

This is a part of the effort to expose timing metrics to net
embedders.

BUG=648346
==========

[commit-bot: I haz the power, 2016-09-20 21:58:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 22:00:29]

Description was changed from

==========
Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the 
implementation for H2 and QUIC separately.

This is a part of the effort to expose timing metrics to net
embedders.

BUG=648346
==========

to

==========
Adds GetLoadTimingInfo to net::BidirectionalStreamImpl

This CL adds a virtual function to net::BidirectionalStreamImpl to
get LoadTimingInfo. There will be follow-up CLs to add the
implementation for H2 and QUIC separately.

This is a part of the effort to expose timing metrics to net
embedders.

BUG=648346

Committed: https://crrev.com/ba8de43245cf4da038b3a178b6908ad2404466be
Cr-Commit-Position: refs/heads/master@{#419864}
==========

[commit-bot: I haz the power, 2016-09-20 22:00:30]

Patchset 2 (id:??) landed as
https://crrev.com/ba8de43245cf4da038b3a178b6908ad2404466be
Cr-Commit-Position: refs/heads/master@{#419864}