Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2349353003: CPDF_Document friend cleanup (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

CPDF_Document friend cleanup Remove CPDF_Creator and CPDF_Parser as friends of CPDF_Document. Move all member variables to the private section, and add CPDF_TestDocument as a private friend. Committed: https://pdfium.googlesource.com/pdfium/+/0d726c0c9931979d9b0594d56b52c861e08e09ba

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 1 3 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-20 14:24:39 UTC) #4
npm
lgtm
4 years, 3 months ago (2016-09-20 14:42:13 UTC) #5
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-20 17:28:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349353003/20001
4 years, 3 months ago (2016-09-20 19:43:02 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:05:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0d726c0c9931979d9b0594d56b52c861e08e...

Powered by Google App Engine
This is Rietveld 408576698