Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js

Issue 2349343002: DevTools: introduce persistence/ module (Closed)
Patch Set: reupload Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
index 71d5547e59a9dc8d4098047bd335072f5c2b5031..e2a6aa403d172774e98f215375a170276975560e 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
@@ -202,13 +202,12 @@ WebInspector.NetworkProject.prototype = {
* @param {!WebInspector.ContentProvider} contentProvider
* @param {?WebInspector.ResourceTreeFrame} frame
* @param {boolean=} isContentScript
- * @return {?WebInspector.UISourceCode}
+ * @return {!WebInspector.UISourceCode}
*/
addFile: function(contentProvider, frame, isContentScript)
{
var uiSourceCode = this._createFile(contentProvider, frame, isContentScript || false);
- if (uiSourceCode)
- this._addUISourceCodeWithProvider(uiSourceCode, contentProvider);
+ this._addUISourceCodeWithProvider(uiSourceCode, contentProvider);
return uiSourceCode;
},
@@ -270,10 +269,8 @@ WebInspector.NetworkProject.prototype = {
return;
}
var uiSourceCode = this._createFile(script, WebInspector.ResourceTreeFrame.fromScript(script), script.isContentScript());
- if (uiSourceCode) {
- uiSourceCode[WebInspector.NetworkProject._scriptSymbol] = script;
- this._addUISourceCodeWithProvider(uiSourceCode, script);
- }
+ uiSourceCode[WebInspector.NetworkProject._scriptSymbol] = script;
+ this._addUISourceCodeWithProvider(uiSourceCode, script);
},
/**
@@ -287,10 +284,8 @@ WebInspector.NetworkProject.prototype = {
var originalContentProvider = header.originalContentProvider();
var uiSourceCode = this._createFile(originalContentProvider, WebInspector.ResourceTreeFrame.fromStyleSheet(header), false);
- if (uiSourceCode) {
- uiSourceCode[WebInspector.NetworkProject._styleSheetSymbol] = header;
- this._addUISourceCodeWithProvider(uiSourceCode, originalContentProvider);
- }
+ uiSourceCode[WebInspector.NetworkProject._styleSheetSymbol] = header;
+ this._addUISourceCodeWithProvider(uiSourceCode, originalContentProvider);
},
/**
@@ -341,10 +336,8 @@ WebInspector.NetworkProject.prototype = {
return;
var uiSourceCode = this._createFile(resource, WebInspector.ResourceTreeFrame.fromResource(resource), false);
- if (uiSourceCode) {
- uiSourceCode[WebInspector.NetworkProject._resourceSymbol] = resource;
- this._addUISourceCodeWithProvider(uiSourceCode, resource);
- }
+ uiSourceCode[WebInspector.NetworkProject._resourceSymbol] = resource;
+ this._addUISourceCodeWithProvider(uiSourceCode, resource);
},
/**
@@ -382,14 +375,11 @@ WebInspector.NetworkProject.prototype = {
* @param {!WebInspector.ContentProvider} contentProvider
* @param {?WebInspector.ResourceTreeFrame} frame
* @param {boolean} isContentScript
- * @return {?WebInspector.UISourceCode}
+ * @return {!WebInspector.UISourceCode}
*/
_createFile: function(contentProvider, frame, isContentScript)
{
var url = contentProvider.contentURL();
- if (this._networkMapping.hasMappingForNetworkURL(url))
- return null;
-
var project = this._workspaceProject(frame, isContentScript);
var uiSourceCode = project.createUISourceCode(url, contentProvider.contentType());
uiSourceCode[WebInspector.NetworkProject._targetSymbol] = this.target();

Powered by Google App Engine
This is Rietveld 408576698