DevTools: introduce persistence/ module

DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman

Committed: https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3
Cr-Commit-Position: refs/heads/master@{#421007}

[lushnikov, 2016-09-22 05:04:52]

Description was changed from

==========
DevTools: introduce WI.UIBindings

The WI.UIBindings replaces WI.NetworkMapping and is responsible
for binding Network UISourceCodes with FileSystem UISourceCodes.
The NetworkMapping becomes unneeded for this.
==========

to

==========
DevTools: always create UISourceCode for network resource

Today, we do not create UISourceCode for network resource
if there's an associated UISourceCode from the file system.

This patch starts always creating UISourceCode for network resources. If there's
a corresponding UISourceCode from FileSystem, then a lightweight binding between
the two is created, which syncs their contents.

The WI.Persistence is responsible for binding network UISourceCodes to file
system UISourceCodes and for
syncing their contents.

BUG=none
R=dgozman, pfeldman
==========

[lushnikov, 2016-09-22 05:05:04]

please, take a look

[lushnikov, 2016-09-22 05:05:12]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 05:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-09-22 05:06:42]

Description was changed from

==========
DevTools: always create UISourceCode for network resource

Today, we do not create UISourceCode for network resource
if there's an associated UISourceCode from the file system.

This patch starts always creating UISourceCode for network resources. If there's
a corresponding UISourceCode from FileSystem, then a lightweight binding between
the two is created, which syncs their contents.

The WI.Persistence is responsible for binding network UISourceCodes to file
system UISourceCodes and for
syncing their contents.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: always create UISourceCode for network resource

Today, we do not create UISourceCode for network resource
if there's an associated UISourceCode from the file system.

This patch starts always creating UISourceCode for network resources. If
there's a corresponding UISourceCode from FileSystem, then a lightweight
binding between the two is created, which syncs their contents.

The WI.Persistence is responsible for binding network UISourceCodes to file
system UISourceCodes and for
syncing their contents.

BUG=none
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-09-22 08:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 08:13:09]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-09-22 16:21:07]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[dgozman, 2016-09-22 19:55:54]

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:21:
fileSystemManager.waitForFileSystems()
We either don't do waitForFileSystems or we listen to events.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/main/Main.js:181:
WebInspector.persistence = new WebInspector.Persistence(WebInspector.workspace,
WebInspector.breakpointManager);
Let's do Persistence.instance().

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:22:
WebInspector.fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded,
this._remap, this),
Let's pass the fileSystemMapping.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:25: }
Let's call this._remap().

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:30:
WebInspector.Persistence.NodePrefix = "(function (exports, require, module,
__filename, __dirname) { ";
_NodePrefix

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:43: for
(var binding of this._bindings.valuesArray())
var binding of bindings

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:89: var
networkUISC = networkURL ? this._workspace.uiSourceCodeForURL(networkURL) :
null;
networkSourceCode

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:95: var
fileUISC = file && projectId ? this._workspace.uiSourceCode(projectId,
file.fileURL) : null;
fileSourceCode

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:103: if
(uiSourceCode[WebInspector.Persistence._binding])
How come? Assert!

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:108: if
(binding.network.isDirty() || binding.persistent.isDirty()) {
We'll have to do something smarter. For now, let's just ignore these and log,
but not more than 10 times. Add TODO.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:158:
other.requestContent().then(currentContent => this._syncContent(binding, other,
currentContent, /** @type {string} */(event.data.content)));
if (Runtime.queryParam("v8only"))
   ...
else
   justCommitIt!

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:235:
return uiSourceCode[WebInspector.Persistence._binding];
|| null

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:254:
this.persistent = persistent;
persistent -> fileSystem

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
(left):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js:52:
this._textEditor.setReadOnly(!this.canEditSource());
Leave it.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js:71:
if (uiSourceCode.project().type() === WebInspector.projectTypes.FileSystem)
Let's add a possible follow-up to remove this layering violation.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:162:
this._removeUISourceCode(binding.network);
TODO(lushnikov): remove this after adding a green bubble.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:89: return
binding.network.isDirty() || binding.persistent.isDirty();
Only check network.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:87:
_onBindingCreated: function(event)
JSDoc

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:95:
this.addUISourceCode(binding.network);
Should preserve focus if it was on closed tab.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:98:
_onBindingRemoved: function(event)
JSDoc

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:227:
var binding = WebInspector.persistence.binding(uiSourceCode)
semicolon

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:216:
_onBindingChanged: function(event)
JSDoc

[lushnikov, 2016-09-23 21:56:14]

The overview of the work:
https://docs.google.com/document/d/12EU7HgFNWBsP_3syPCviHEOmU-Yn-q4kiF6RT_kBm...

Addressed all changes + a few improvements:
1. Call uiSourceCode.forceLoadOnCheckContent on bind event
2. Break binding when fileSystem uiSourceCode gets renamed

Tests included!

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:21:
fileSystemManager.waitForFileSystems()
On 2016/09/22 19:55:53, dgozman wrote:
> We either don't do waitForFileSystems or we listen to events.

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/main/Main.js:181:
WebInspector.persistence = new WebInspector.Persistence(WebInspector.workspace,
WebInspector.breakpointManager);
On 2016/09/22 19:55:53, dgozman wrote:
> Let's do Persistence.instance().

How would I pass arguments in this case?

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:22:
WebInspector.fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded,
this._remap, this),
On 2016/09/22 19:55:53, dgozman wrote:
> Let's pass the fileSystemMapping.

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:25: }
On 2016/09/22 19:55:53, dgozman wrote:
> Let's call this._remap().

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:30:
WebInspector.Persistence.NodePrefix = "(function (exports, require, module,
__filename, __dirname) { ";
On 2016/09/22 19:55:53, dgozman wrote:
> _NodePrefix

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:43: for
(var binding of this._bindings.valuesArray())
On 2016/09/22 19:55:53, dgozman wrote:
> var binding of bindings

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:89: var
networkUISC = networkURL ? this._workspace.uiSourceCodeForURL(networkURL) :
null;
On 2016/09/22 19:55:53, dgozman wrote:
> networkSourceCode

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:95: var
fileUISC = file && projectId ? this._workspace.uiSourceCode(projectId,
file.fileURL) : null;
On 2016/09/22 19:55:53, dgozman wrote:
> fileSourceCode

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:103: if
(uiSourceCode[WebInspector.Persistence._binding])
On 2016/09/22 19:55:53, dgozman wrote:
> How come? Assert!

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:108: if
(binding.network.isDirty() || binding.persistent.isDirty()) {
On 2016/09/22 19:55:53, dgozman wrote:
> We'll have to do something smarter. For now, let's just ignore these and log,
> but not more than 10 times. Add TODO.

Did this without the "10 times" thingy - there won't be more errors than opened
tabs in the editor.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:158:
other.requestContent().then(currentContent => this._syncContent(binding, other,
currentContent, /** @type {string} */(event.data.content)));
On 2016/09/22 19:55:53, dgozman wrote:
> if (Runtime.queryParam("v8only"))
>    ...
> else
>    justCommitIt!

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:235:
return uiSourceCode[WebInspector.Persistence._binding];
On 2016/09/22 19:55:53, dgozman wrote:
> || null

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:254:
this.persistent = persistent;
On 2016/09/22 19:55:53, dgozman wrote:
> persistent -> fileSystem

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
(left):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js:52:
this._textEditor.setReadOnly(!this.canEditSource());
On 2016/09/22 19:55:53, dgozman wrote:
> Leave it.

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js:71:
if (uiSourceCode.project().type() === WebInspector.projectTypes.FileSystem)
On 2016/09/22 19:55:53, dgozman wrote:
> Let's add a possible follow-up to remove this layering violation.

Done:
https://docs.google.com/document/d/12EU7HgFNWBsP_3syPCviHEOmU-Yn-q4kiF6RT_kBm...

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:162:
this._removeUISourceCode(binding.network);
On 2016/09/22 19:55:54, dgozman wrote:
> TODO(lushnikov): remove this after adding a green bubble.

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:89: return
binding.network.isDirty() || binding.persistent.isDirty();
On 2016/09/22 19:55:54, dgozman wrote:
> Only check network.

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:87:
_onBindingCreated: function(event)
On 2016/09/22 19:55:54, dgozman wrote:
> JSDoc

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:95:
this.addUISourceCode(binding.network);
On 2016/09/22 19:55:54, dgozman wrote:
> Should preserve focus if it was on closed tab.

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:98:
_onBindingRemoved: function(event)
On 2016/09/22 19:55:54, dgozman wrote:
> JSDoc

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:227:
var binding = WebInspector.persistence.binding(uiSourceCode)
On 2016/09/22 19:55:54, dgozman wrote:
> semicolon

Done.

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/2349343002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:216:
_onBindingChanged: function(event)
On 2016/09/22 19:55:54, dgozman wrote:
> JSDoc

Done.

[lushnikov, 2016-09-23 22:10:39]

Description was changed from

==========
DevTools: always create UISourceCode for network resource

Today, we do not create UISourceCode for network resource
if there's an associated UISourceCode from the file system.

This patch starts always creating UISourceCode for network resources. If
there's a corresponding UISourceCode from FileSystem, then a lightweight
binding between the two is created, which syncs their contents.

The WI.Persistence is responsible for binding network UISourceCodes to file
system UISourceCodes and for
syncing their contents.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce persistence/ module

Today, we do not create UISourceCode for network resource
if there's an associated UISourceCode from the file system.

This patch starts always creating UISourceCode for network resources. If
there's a corresponding UISourceCode from FileSystem, then a lightweight
binding between the two is created, which syncs their contents.

The WI.Persistence is responsible for binding network UISourceCodes to
file system UISourceCodes and for syncing their contents.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman
==========

[lushnikov, 2016-09-23 22:18:01]

Description was changed from

==========
DevTools: introduce persistence/ module

Today, we do not create UISourceCode for network resource
if there's an associated UISourceCode from the file system.

This patch starts always creating UISourceCode for network resources. If
there's a corresponding UISourceCode from FileSystem, then a lightweight
binding between the two is created, which syncs their contents.

The WI.Persistence is responsible for binding network UISourceCodes to
file system UISourceCodes and for syncing their contents.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman
==========

[dgozman, 2016-09-23 23:03:21]

lgtm

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html:19:
function onBindingCreated()
Let's also dump before binding.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html:71:
InspectorTest.addResult("    " + url);
Let's add the line.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file.html
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file.html:29:
var binding = event.data;
Let's dump it.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt:1:
Verify that search across all files filters out matches in uiSourceCodes with
fileSystem binding.
omits filesystem uiSourceCodes with binding to network.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt:3:
BindingCreated
Before and after.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt:8:
Running: Edit network uiSourceCode
Let's dump before.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:1:
var initialize_PersistenceTest = function() {
Let's add a test for "didn't bind because of isDirty flag".

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt:9: url
http://localhost/index.html is mapped to null
suspicicous

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:113:
WebInspector.console.log(WebInspector.UIString("Failed to map %s. Save your
changes and reload page.", binding.network.name()));
"%s can not be persisted to file system due to unsaved changes."

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:99:
return;
select if isSelected

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:254:
uiSourceCode = binding ? binding.network : uiSourceCode;
Let's add a test for this line.

[lushnikov, 2016-09-24 00:30:50]

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html:19:
function onBindingCreated()
On 2016/09/23 23:03:20, dgozman wrote:
> Let's also dump before binding.

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html:71:
InspectorTest.addResult("    " + url);
On 2016/09/23 23:03:20, dgozman wrote:
> Let's add the line.

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file.html
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file.html:29:
var binding = event.data;
On 2016/09/23 23:03:20, dgozman wrote:
> Let's dump it.

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt:1:
Verify that search across all files filters out matches in uiSourceCodes with
fileSystem binding.
On 2016/09/23 23:03:21, dgozman wrote:
> omits filesystem uiSourceCodes with binding to network.

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt:3:
BindingCreated
On 2016/09/23 23:03:20, dgozman wrote:
> Before and after.

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt:8:
Running: Edit network uiSourceCode
On 2016/09/23 23:03:21, dgozman wrote:
> Let's dump before.

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:1:
var initialize_PersistenceTest = function() {
On 2016/09/23 23:03:21, dgozman wrote:
> Let's add a test for "didn't bind because of isDirty flag".

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt:9: url
http://localhost/index.html is mapped to null
On 2016/09/23 23:03:21, dgozman wrote:
> suspicicous

This happens for the same reason as the rest of the calls in this block.
Since we don't query fileMapping any more, the workspace doesn't have these
urls.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:113:
WebInspector.console.log(WebInspector.UIString("Failed to map %s. Save your
changes and reload page.", binding.network.name()));
On 2016/09/23 23:03:21, dgozman wrote:
> "%s can not be persisted to file system due to unsaved changes."

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:99:
return;
On 2016/09/23 23:03:21, dgozman wrote:
> select if isSelected

Done.

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js:254:
uiSourceCode = binding ? binding.network : uiSourceCode;
On 2016/09/23 23:03:21, dgozman wrote:
> Let's add a test for this line.

Done.

[lushnikov, 2016-09-24 00:31:01]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 00:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-09-24 02:34:34]

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt
(right):

https://codereview.chromium.org/2349343002/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt:9: url
http://localhost/index.html is mapped to null
On 2016/09/24 00:30:50, lushnikov wrote:
> On 2016/09/23 23:03:21, dgozman wrote:
> > suspicicous
> 
> This happens for the same reason as the rest of the calls in this block.
> Since we don't query fileMapping any more, the workspace doesn't have these
> urls.

I see. But this means uiSourceCodeForURL(url) return null which is strange.
Could you please double-check and maybe change the test?

[commit-bot: I haz the power, 2016-09-24 03:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 03:01:14]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-09-24 06:01:29]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 06:01:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-09-24 06:01:54]

Added some sanity to the test; please, take a look!

[commit-bot: I haz the power, 2016-09-24 07:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 07:46:16]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-24 16:17:07]

Thanks, looks good.

https://codereview.chromium.org/2349343002/diff/220001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/inspector/workspace-mapping.html (right):

https://codereview.chromium.org/2349343002/diff/220001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector/workspace-mapping.html:63:
dumpUISourceCodeForURL("http://www.example.com/index.html");
I think that now this block does not make sense, so let's remove projects,
workspace and UISourceCodes from this test and only test fileSystemMapping.

[lushnikov, 2016-09-26 16:43:34]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 16:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:15:27]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-09-26 21:45:08]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-09-26 21:45:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2349343002/#ps240001
(title: "simplify test")

[commit-bot: I haz the power, 2016-09-26 21:45:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:53:50]

Description was changed from

==========
DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-09-26 21:53:52]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-09-26 21:55:25]

Description was changed from

==========
DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman

Committed: https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3
Cr-Commit-Position: refs/heads/master@{#421007}
==========

[commit-bot: I haz the power, 2016-09-26 21:55:27]

Patchset 13 (id:??) landed as
https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3
Cr-Commit-Position: refs/heads/master@{#421007}