Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 234933002: Dispatch change event for Input type=range for touchEnd (Closed)

Created:
6 years, 8 months ago by Habib Virji
Modified:
6 years, 8 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Dispatch change event for Input type=range for touchEnd Adds dispatch change event at touchEnd. R=tkent@chromium.org, keishi1@chromium.org BUG=361335 TEST=On touch start check input event is dispatched and on touch end check change event is dispatched Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171455

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M LayoutTests/fast/forms/range/slider-onchange-event.html View 1 1 chunk +12 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/range/slider-onchange-event-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Habib Virji
At touch end dispatch change event for range input type
6 years, 8 months ago (2014-04-11 10:21:28 UTC) #1
tkent
lgtm https://codereview.chromium.org/234933002/diff/1/LayoutTests/fast/forms/range/slider-onchange-event.html File LayoutTests/fast/forms/range/slider-onchange-event.html (right): https://codereview.chromium.org/234933002/diff/1/LayoutTests/fast/forms/range/slider-onchange-event.html#newcode29 LayoutTests/fast/forms/range/slider-onchange-event.html:29: var y = slider.offsetTop + slider.clientHeight/2; nit: needs ...
6 years, 8 months ago (2014-04-14 00:35:46 UTC) #2
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-14 08:37:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/234933002/20001
6 years, 8 months ago (2014-04-14 08:37:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 09:41:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-14 09:41:58 UTC) #6
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-14 12:24:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/234933002/20001
6 years, 8 months ago (2014-04-14 12:24:32 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 12:26:09 UTC) #9
Message was sent while issue was closed.
Change committed as 171455

Powered by Google App Engine
This is Rietveld 408576698