Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 23493028: Revert 221874 "Implement Desktop Media Picker (Mac version) for ..." (Closed)

Created:
7 years, 3 months ago by Chris Evans
Modified:
7 years, 3 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221874 "Implement Desktop Media Picker (Mac version) for ..." > Implement Desktop Media Picker (Mac version) for the Desktop Capture API > > This CL implements DesktopMediaPicker for the Mac used by the Desktop Capture API to present the user with a list of sources (including live thumbnails) to use. > > BUG=237907 > > Review URL: https://chromiumcodereview.appspot.com/23944003 TBR=dcaiafa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -853 lines) Patch
M trunk/src/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_bridge.h View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_bridge.mm View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h View 1 chunk +0 lines, -30 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm View 1 chunk +0 lines, -30 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h View 1 chunk +0 lines, -62 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 1 chunk +0 lines, -291 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm View 1 chunk +0 lines, -250 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h View 1 chunk +0 lines, -46 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.mm View 1 chunk +0 lines, -59 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
7 years, 3 months ago (2013-09-07 06:02:37 UTC) #1
Chris Evans
7 years, 3 months ago (2013-09-07 06:03:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221901.

Powered by Google App Engine
This is Rietveld 408576698