Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 23493024: Add live Javascript viewer for GM expectations (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, borenet
Visibility:
Public.

Description

Add live Javascript viewer for GM expectations BUG=skia:1599 This is similar to the live viewer for GM actuals, at https://skia-autogen.googlecode.com/svn/gm-actual/view.html It will be the basis for GM expectations analysis as described in bug 1599. R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=11280

Patch Set 1 #

Patch Set 2 : little_comment_fixes #

Patch Set 3 : more_comments #

Total comments: 5

Patch Set 4 : ravi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -0 lines) Patch
expectations/gm/loader.js View 1 1 chunk +52 lines, -0 lines 0 comments Download
expectations/gm/view-platform.html View 1 2 3 1 chunk +153 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 3. To try it out, go to http://c128.i.corp.google.com/skia/white/trunk/expectations/gm/view-platform.html
7 years, 3 months ago (2013-09-06 21:24:03 UTC) #1
rmistry
LGTM https://codereview.chromium.org/23493024/diff/5001/expectations/gm/view-platform.html File expectations/gm/view-platform.html (right): https://codereview.chromium.org/23493024/diff/5001/expectations/gm/view-platform.html#newcode133 expectations/gm/view-platform.html:133: href="http://chromium-skia-gm.commondatastorage.googleapis.com/gm/{{image.hashType}}/{{result.test}}/{{image.hashValue}}.png"> [optional] We should probably add the base ...
7 years, 3 months ago (2013-09-09 15:46:00 UTC) #2
epoger
https://codereview.chromium.org/23493024/diff/5001/expectations/gm/view-platform.html File expectations/gm/view-platform.html (right): https://codereview.chromium.org/23493024/diff/5001/expectations/gm/view-platform.html#newcode133 expectations/gm/view-platform.html:133: href="http://chromium-skia-gm.commondatastorage.googleapis.com/gm/{{image.hashType}}/{{result.test}}/{{image.hashValue}}.png"> On 2013/09/09 15:46:00, rmistry wrote: > [optional] We ...
7 years, 3 months ago (2013-09-09 20:09:39 UTC) #3
rmistry
LGTM again https://codereview.chromium.org/23493024/diff/5001/expectations/gm/view-platform.html File expectations/gm/view-platform.html (right): https://codereview.chromium.org/23493024/diff/5001/expectations/gm/view-platform.html#newcode134 expectations/gm/view-platform.html:134: {{image.hashValue}}</a><br> On 2013/09/09 20:09:40, epoger wrote: > ...
7 years, 3 months ago (2013-09-09 20:11:56 UTC) #4
epoger
7 years, 3 months ago (2013-09-15 02:18:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r11280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698