Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: ui/views/widget/widget_hwnd_utils.cc

Issue 23493022: Don't pass in WS_EX_TRANSPARENT in the window style in classic mode in AURA as that causes the wind… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_hwnd_utils.cc
===================================================================
--- ui/views/widget/widget_hwnd_utils.cc (revision 221492)
+++ ui/views/widget/widget_hwnd_utils.cc (working copy)
@@ -63,8 +63,13 @@
// DwmExtendFrameIntoClientArea passing -1 as the margins.
if (params.opacity == Widget::InitParams::TRANSLUCENT_WINDOW) {
#if defined(USE_AURA)
- if (ui::win::IsAeroGlassEnabled())
+ if (ui::win::IsAeroGlassEnabled()) {
*ex_style |= WS_EX_COMPOSITED;
+ } else {
+ // In classic mode, the WS_EX_TRANSPARENT style causes the window to not
+ // paint correctly.
+ *ex_style &= ~WS_EX_TRANSPARENT;
sky 2013/09/06 21:03:47 Won't this cause bad things to happen where we are
ananta 2013/09/06 21:23:26 The HWNDMessageHandler::SetInitialFocus function i
ananta 2013/09/06 22:08:50 As per our discussion we pass in accept_events = t
+ }
#else
*ex_style |= WS_EX_LAYERED;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698