Don't pass in WS_EX_TRANSPARENT in the window style in classic mode in AURA as that causes the wind…

Set accept_events to true when we create top level windowsin desktop AURA. This ensures that we don't end
up using WS_EX_TRANSPARENT when the actual window is created. This causes painting and flickering issues in AURA.
Will investigate that later.

BUG=282628
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221833

[sky, 2013-09-06 21:03:46]

https://codereview.chromium.org/23493022/diff/4001/ui/views/widget/widget_hwn...
File ui/views/widget/widget_hwnd_utils.cc (right):

https://codereview.chromium.org/23493022/diff/4001/ui/views/widget/widget_hwn...
ui/views/widget/widget_hwnd_utils.cc:71: *ex_style &= ~WS_EX_TRANSPARENT;
Won't this cause bad things to happen where we are using WS_EX_TRANSPARENT?

[ananta, 2013-09-06 21:23:26]

https://codereview.chromium.org/23493022/diff/4001/ui/views/widget/widget_hwn...
File ui/views/widget/widget_hwnd_utils.cc (right):

https://codereview.chromium.org/23493022/diff/4001/ui/views/widget/widget_hwn...
ui/views/widget/widget_hwnd_utils.cc:71: *ex_style &= ~WS_EX_TRANSPARENT;
On 2013/09/06 21:03:47, sky wrote:
> Won't this cause bad things to happen where we are using WS_EX_TRANSPARENT?
The HWNDMessageHandler::SetInitialFocus function is the only place we need to
worry about, I think. It does not set focus if the window has either of the
WS_EX_TRANSPARENT or WS_EX_NOACTIVATE.
In any case as this style brings in bugs, we should not be using it.

[ananta, 2013-09-06 22:08:50]

https://codereview.chromium.org/23493022/diff/4001/ui/views/widget/widget_hwn...
File ui/views/widget/widget_hwnd_utils.cc (right):

https://codereview.chromium.org/23493022/diff/4001/ui/views/widget/widget_hwn...
ui/views/widget/widget_hwnd_utils.cc:71: *ex_style &= ~WS_EX_TRANSPARENT;
On 2013/09/06 21:03:47, sky wrote:
> Won't this cause bad things to happen where we are using WS_EX_TRANSPARENT?

As per our discussion we pass in accept_events = true when creating windows in
desktop AURA. I will look into the painting issues with transparent separately.

[sky, 2013-09-06 22:11:12]

LGTM with the following change

https://codereview.chromium.org/23493022/diff/19001/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right):

https://codereview.chromium.org/23493022/diff/19001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:80:
init_params.accept_events = true;
You an nuke this entirely now (since true is the default).

[ananta, 2013-09-06 22:21:49]

https://codereview.chromium.org/23493022/diff/19001/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right):

https://codereview.chromium.org/23493022/diff/19001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:80:
init_params.accept_events = true;
On 2013/09/06 22:11:12, sky wrote:
> You an nuke this entirely now (since true is the default).

Done.

[ananta, 2013-09-07 00:36:08]

Committed patchset #4 manually as r221833 (presubmit successful).