Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2349283002: Remove explict frame removal from fetch-request-css-base-url.html test (Closed)

Created:
4 years, 3 months ago by iclelland
Modified:
4 years, 3 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove explict frame removal from fetch-request-css-base-url.html test This was causing occasional test failures on the WebKit Win7 Dbg builder, as the frame variable was sometimes not set when the message from the service worker was being handled. Since the frames created by with_iframe() are auto-removed now, the explicit removal isn't necessary anymore. R=falken@chromium.org BUG=648247 Committed: https://crrev.com/b4c7dfe047c13a76225f03badacd2e5a46f22982 Cr-Commit-Position: refs/heads/master@{#419736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-base-url.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
iclelland
+r falken -- this should fix the Win7 flake on this test, but I wanted ...
4 years, 3 months ago (2016-09-19 17:52:06 UTC) #5
falken
lgtm. Interesting bug! We should try to remove unnecessary frame.remove() in our tests.
4 years, 3 months ago (2016-09-20 04:06:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349283002/1
4 years, 3 months ago (2016-09-20 13:11:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 13:15:54 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 13:17:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4c7dfe047c13a76225f03badacd2e5a46f22982
Cr-Commit-Position: refs/heads/master@{#419736}

Powered by Google App Engine
This is Rietveld 408576698