Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2349273002: Avoid kStrokeAndFill_Style in BorderShadowLayerDelegate::OnPaintLayer (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
Evan Stade, bruthig, reed1
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid kStrokeAndFill_Style in BorderShadowLayerDelegate::OnPaintLayer We're looking at deprecating kStrokeAndFill_Style in Skia, so this CL's main focus is removing the use of the flag. While in this area, I've also updated the impl to draw the shadow using Canvas::DrawRoundRect instead of going through a path. R=reed@google.com,bruthig@chromium.org Committed: https://crrev.com/03b81153a7524cce82afc1c8d18838574757c46b Cr-Commit-Position: refs/heads/master@{#419541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M ui/views/animation/ink_drop_painted_layer_delegates.cc View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
f(malita)
I presume the stroke bit of the shadow is not intentional/significant, because we're not setting ...
4 years, 3 months ago (2016-09-19 17:07:49 UTC) #4
reed1
lgtm
4 years, 3 months ago (2016-09-19 17:41:38 UTC) #7
Evan Stade
lgtm
4 years, 3 months ago (2016-09-19 19:42:48 UTC) #8
bruthig
lgtm
4 years, 3 months ago (2016-09-19 19:56:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349273002/1
4 years, 3 months ago (2016-09-19 20:00:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 20:07:11 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:03:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03b81153a7524cce82afc1c8d18838574757c46b
Cr-Commit-Position: refs/heads/master@{#419541}

Powered by Google App Engine
This is Rietveld 408576698