Do not create WebAPK via add-to-homescreen menu item if manifest is not WebAPK-compatible

Do not create WebAPK via add-to-homescreen menu item if manifest is not WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None

Committed: https://crrev.com/73f12a7222661ba2f81106c971bb25449ce78e9b
Cr-Commit-Position: refs/heads/master@{#419949}

[pkotwicz, 2016-09-20 03:13:54]

Description was changed from

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

BUG=648491
TEST=None
==========

to

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the login in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None
==========

[pkotwicz, 2016-09-20 03:13:54]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-09-20 03:14:13]

Description was changed from

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the login in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None
==========

to

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None
==========

[pkotwicz, 2016-09-20 03:14:25]

Dominick can you please take a look?

[dominickn, 2016-09-20 03:25:44]

lgtm

[pkotwicz, 2016-09-21 00:38:24]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 02:18:04]

Description was changed from

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None
==========

to

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None
==========

[commit-bot: I haz the power, 2016-09-21 02:18:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 02:20:05]

Description was changed from

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None
==========

to

==========
Do not create WebAPK via add-to-homescreen menu item if manifest is not
WebAPK-compatible

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None

Committed: https://crrev.com/73f12a7222661ba2f81106c971bb25449ce78e9b
Cr-Commit-Position: refs/heads/master@{#419949}
==========

[commit-bot: I haz the power, 2016-09-21 02:20:06]

Patchset 1 (id:??) landed as
https://crrev.com/73f12a7222661ba2f81106c971bb25449ce78e9b
Cr-Commit-Position: refs/heads/master@{#419949}