Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2349253004: Restrict WebShare to secure contexts. (Closed)

Created:
4 years, 3 months ago by Sam McNally
Modified:
4 years, 3 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict WebShare to secure contexts. BUG=645005 Committed: https://crrev.com/6a1c8d418dcc016eaf034d357cf71b47e1d49286 Cr-Commit-Position: refs/heads/master@{#419720}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/webshare-on-insecure-origin.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Sam McNally
4 years, 3 months ago (2016-09-20 08:34:47 UTC) #5
haraken
LGTM
4 years, 3 months ago (2016-09-20 08:52:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349253004/20001
4 years, 3 months ago (2016-09-20 10:43:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-20 10:58:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 11:01:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a1c8d418dcc016eaf034d357cf71b47e1d49286
Cr-Commit-Position: refs/heads/master@{#419720}

Powered by Google App Engine
This is Rietveld 408576698