Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2349213004: Clean up some code in template_url_prepopuplate_data.cc. (Closed)

Created:
4 years, 3 months ago by Peter Kasting
Modified:
4 years, 3 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some code in template_url_prepopuplate_data.cc. Inspired by https://codereview.chromium.org/2347973002/ . BUG=none TEST=none Committed: https://crrev.com/ab70b34bc55cb6401bab5d70a740a32e7c323b10 Cr-Commit-Position: refs/heads/master@{#419588}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M components/search_engines/template_url_prepopulate_data.cc View 1 3 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Peter Kasting
4 years, 3 months ago (2016-09-19 20:37:48 UTC) #3
Ian Wen
https://codereview.chromium.org/2349213004/diff/1/components/search_engines/template_url_prepopulate_data.cc File components/search_engines/template_url_prepopulate_data.cc (right): https://codereview.chromium.org/2349213004/diff/1/components/search_engines/template_url_prepopulate_data.cc#newcode1249 components/search_engines/template_url_prepopulate_data.cc:1249: if (begin == std::string::npos) Do you mean territory_delim here?
4 years, 3 months ago (2016-09-19 20:51:31 UTC) #7
Ian Wen
lgtm the 2nd patchset. Thanks for this clean up, which makes the other CL easier. ...
4 years, 3 months ago (2016-09-19 20:57:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349213004/20001
4 years, 3 months ago (2016-09-19 21:52:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 22:05:11 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 22:07:32 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab70b34bc55cb6401bab5d70a740a32e7c323b10
Cr-Commit-Position: refs/heads/master@{#419588}

Powered by Google App Engine
This is Rietveld 408576698