Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 2349213003: Opus: Fixes overflow in CNG (Closed)

Created:
4 years, 3 months ago by flim-chromium
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Opus: Fixes overflow in CNG Patching in fix from upstream https://git.xiph.org/?p=opus.git;a=commitdiff;h=5da0498a3e23339aaceba659a97e935031d5693d BUG=648061 Committed: https://crrev.com/bb7f9001306231ccea72c29836d601e6ffb8533d Cr-Commit-Position: refs/heads/master@{#419724}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/opus/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/opus/src/silk/CNG.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
flim-chromium
Hi, here's another one. Can you PTAL? Thanks!
4 years, 3 months ago (2016-09-19 19:09:39 UTC) #4
henrika (OOO until Aug 14)
Need assistance from minyue@ here
4 years, 3 months ago (2016-09-20 07:23:58 UTC) #7
minyue
lgtm
4 years, 3 months ago (2016-09-20 07:25:27 UTC) #8
henrika (OOO until Aug 14)
LGTM
4 years, 3 months ago (2016-09-20 07:52:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349213003/20001
4 years, 3 months ago (2016-09-20 10:36:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 12:25:35 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:27:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb7f9001306231ccea72c29836d601e6ffb8533d
Cr-Commit-Position: refs/heads/master@{#419724}

Powered by Google App Engine
This is Rietveld 408576698