Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2349203002: [NTP Snippets] Try to fix crash in NTPSnippetsService::RescheduleFetching (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Try to fix crash in NTPSnippetsService::RescheduleFetching and also in ::FetchSnippets BUG=647920, 648201 Committed: https://crrev.com/ae5a6bfdce8c72fc563fd3331823fb59d43ebe8c Cr-Commit-Position: refs/heads/master@{#419451}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 2 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Marc Treib
PTAL! I'm also trying to see if I can reproduce anything, but that seems unlikely...
4 years, 3 months ago (2016-09-19 14:04:34 UTC) #4
Michael van Ouwerkerk
lgtm Not sure how any of that would be null, but there are not that ...
4 years, 3 months ago (2016-09-19 14:17:18 UTC) #5
Marc Treib
On 2016/09/19 14:17:18, Michael van Ouwerkerk wrote: > lgtm > > Not sure how any ...
4 years, 3 months ago (2016-09-19 14:25:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349203002/20001
4 years, 3 months ago (2016-09-19 14:29:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 14:33:22 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 14:35:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae5a6bfdce8c72fc563fd3331823fb59d43ebe8c
Cr-Commit-Position: refs/heads/master@{#419451}

Powered by Google App Engine
This is Rietveld 408576698