adding HtmlEscape to dart:convert

pkg/unittest/lib/html_enhanced_config.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A simple unit test library for running tests in a browser.
  *
  * Provides enhanced HTML output with collapsible group headers
  * and other at-a-glance information about the test results.
  */
 library unittest_html_enhanced_config;
 
 import 'dart:async';
 import 'dart:collection' show LinkedHashMap;
+import 'dart:convert';
 import 'dart:html';
 import 'unittest.dart';
 
 class HtmlEnhancedConfiguration extends SimpleConfiguration {
   /** Whether this is run within dartium layout tests. */
   final bool _isLayoutTest;
   HtmlEnhancedConfiguration(this._isLayoutTest);
 
   var _onErrorSubscription = null;
   var _onMessageSubscription = null;
@@ skipping 203 matching lines @@
 
       document.body.children.clear();
       document.body.children.add(te);
     }
   }
 
   void _buildRow(TestCase test_, Element te, String groupID, bool isVisible) {
     var background = 'unittest-row-${test_.id % 2 == 0 ? "even" : "odd"}';
     var display = '${isVisible ? "unittest-row" : "unittest-row-hidden"}';
 
-    // TODO (prujohn@gmail.com) I had to borrow this from html_print.dart
-    // Probably should put it in some more common location.
-    String _htmlEscape(String string) {
-      return string.replaceAll('&', '&')
-                   .replaceAll('<','&lt;')
-                   .replaceAll('>','&gt;');
-    }
-
     addRowElement(id, status, description){
       te.children.add(
         new Element.html(
           ''' <div>
                 <div class='$display unittest-row-${groupID} $background'>
                   <div ${_isIE ? "style='display:inline-block' ": ""}
                        class='unittest-row-id'>$id</div>
                   <div ${_isIE ? "style='display:inline-block' ": ""}
                        class="unittest-row-status unittest-${test_.result}">
                        $status</div>
                   <div ${_isIE ? "style='display:inline-block' ": ""}
                        class='unittest-row-description'>$description</div>
                 </div>
               </div>'''
         )
       );
     }
 
     if (!test_.isComplete) {
        addRowElement('${test_.id}', 'NO STATUS', 'Test did not complete.');
        return;
     }
 
     addRowElement('${test_.id}', '${test_.result.toUpperCase()}',
-        '${test_.description}. ${_htmlEscape(test_.message)}');
+        '${test_.description}. ${HTML_ESCAPE.convert(test_.message)}');
 
     if (test_.stackTrace != null) {
       addRowElement('', '',
-          '<pre>${_htmlEscape(test_.stackTrace.toString())}</pre>');
+          '<pre>${HTML_ESCAPE.convert(test_.stackTrace.toString())}</pre>');
     }
   }
 
 
   static bool get _isIE => window.navigator.userAgent.contains('MSIE');
 
   String get _htmlTestCSS =>
   '''
   body{
     font-size: 14px;
@@ skipping 132 matching lines @@
 
   ''';
 }
 
 void useHtmlEnhancedConfiguration([bool isLayoutTest = false]) {
   unittestConfiguration = isLayoutTest ? _singletonLayout : _singletonNotLayout;
 }
 
 final _singletonLayout = new HtmlEnhancedConfiguration(true);
 final _singletonNotLayout = new HtmlEnhancedConfiguration(false);