Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2349193002: Don't make immediately resolved proxies unresolved (Closed)

Created:
4 years, 3 months ago by Toon Verwaest
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't make immediately resolved proxies unresolved BUG=v8:5209 Committed: https://crrev.com/58507b719ede3bb0723db7c36e93af16cc37abfd Cr-Commit-Position: refs/heads/master@{#39514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M src/ast/scopes.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M src/parsing/parser.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Toon Verwaest
ptal
4 years, 3 months ago (2016-09-19 13:36:38 UTC) #2
adamk
This lgtm, it would be good to further rationalize the use of VariableProxy with Declarations.
4 years, 3 months ago (2016-09-19 17:32:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349193002/1
4 years, 3 months ago (2016-09-19 19:29:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 20:07:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:01:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58507b719ede3bb0723db7c36e93af16cc37abfd
Cr-Commit-Position: refs/heads/master@{#39514}

Powered by Google App Engine
This is Rietveld 408576698