Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2349183003:
Roll clang 280836:281889. (Closed)
|
Created:
4 years, 3 months ago by Nico Modified:
4 years, 3 months ago Reviewers:
hans CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 280836:281889.
* plugin/win: Use absolute path of source file for filtering
* win: more debug info types
* fix for a perf regression
* win: support for more intrinsics as intrinsics
* win: don't allow duplicate uuid attributes
* win: don't inline implicit ctors, dtors in dllimported classes
* linux: link clang against libstdc++ 4.8.5 instead of 4.8.2
* mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib)
Ran `tools/clang/scripts/upload_revision.py 281889`.
BUG=645953
TBR=hans
Committed: https://crrev.com/4143619d2f58609282b29d102a0c274ffe5910df
Cr-Commit-Position: refs/heads/master@{#419767}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll clang 280836:281889. Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 ========== to ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 ==========
The CQ bit was unchecked by thakis@chromium.org
thakis@chromium.org changed reviewers: + hans@chromium.org
Some of the purple asan bots are a bit worrisome, but the tot bots are happy, so hopefully they're just flake.
linux asan is happy now and i claim mac asan is unrelated, filed https://bugs.chromium.org/p/chromium/issues/detail?id=648611 for that
Description was changed from ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 ========== to ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 TBR=hans ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 TBR=hans ========== to ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 TBR=hans ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 TBR=hans ========== to ========== Roll clang 280836:281889. * plugin/win: Use absolute path of source file for filtering * win: more debug info types * fix for a perf regression * win: support for more intrinsics as intrinsics * win: don't allow duplicate uuid attributes * win: don't inline implicit ctors, dtors in dllimported classes * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) Ran `tools/clang/scripts/upload_revision.py 281889`. BUG=645953 TBR=hans Committed: https://crrev.com/4143619d2f58609282b29d102a0c274ffe5910df Cr-Commit-Position: refs/heads/master@{#419767} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4143619d2f58609282b29d102a0c274ffe5910df Cr-Commit-Position: refs/heads/master@{#419767}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2361443002/ by thakis@chromium.org. The reason for reverting is: Broke android builds, see https://crbug.com/648800. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
