pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2349163003: Move towards using WorldImpact for codegen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2349163003: Move towards using WorldImpact for codegen (Closed)

Patch Set: Cleanup. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/backend_impact.dart ('K') | « pkg/compiler/lib/src/js_emitter/native_emitter.dart ('k') | pkg/compiler/lib/src/native/enqueue.dart » ('j') | pkg/compiler/lib/src/universe/world_impact.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index 42fd1e2158ebbfa09d1170d323681593d121bee9..b1036230dd227422ed82ac8f79edc566c9da0c07 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -169,7 +169,7 @@ class ProgramBuilder {

List<Holder> holders = _registry.holders.toList(growable: false);

bool needsNativeSupport = _compiler.enqueuer.codegen.nativeEnqueuer

- .hasInstantiatedNativeClasses();

+ .hasInstantiatedNativeClasses;

assert(!needsNativeSupport || nativeClasses.isNotEmpty);