Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2349143006: DevTools: ConsoleViewFormatter rename _element to _contentElement, _wrapperElement to _element (Closed)

Created:
4 years, 3 months ago by luoe
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: ConsoleViewFormatter rename _element to _contentElement, _wrapperElement to _element Currently in ConsoleViewMessage, there is confusion because message.element() !== message._element message.element() returns message._wrapperElement message.contentElement() returns message._element It should be the case that: message.element() === message._element, which contains our contentElement() This CL renames: _element >> _contentElement _wrapperElement >> _element BUG= Committed: https://crrev.com/30c83e42de4ec101f55f9e53cc1270ced3516bcb Cr-Commit-Position: refs/heads/master@{#420642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 6 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
luoe
Rename, no functionality should be changed. PTAL
4 years, 3 months ago (2016-09-21 18:24:21 UTC) #3
lushnikov
lgtm
4 years, 3 months ago (2016-09-23 00:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349143006/1
4 years, 3 months ago (2016-09-23 17:16:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 17:22:28 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:24:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30c83e42de4ec101f55f9e53cc1270ced3516bcb
Cr-Commit-Position: refs/heads/master@{#420642}

Powered by Google App Engine
This is Rietveld 408576698