Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2349143004:
Plumbing stylus tilt for Mac (Closed)
DescriptionPlumbing stylus tilt for Mac.
Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range
from -1.0 to 1.0 for both axes, but our values lie in [-90,90].
https://developer.apple.com/reference/appkit/nsevent/1534226-tilt
BUG=624814
Committed: https://crrev.com/3c6775ddd60897fd815139b9afe9198c4263dae3
Cr-Commit-Position: refs/heads/master@{#419801}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Change to lround #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== mac tilt BUGr ========== to ========== Plumbing stylus tilt for Mac. Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range from -1.0 to 1.0 for both axes, but our values lie in [-90,90]. https://developer.apple.com/reference/appkit/nsevent/1534226-tilt BUG=624814 ==========
lanwei@chromium.org changed reviewers: + mustaq@chromium.org
lanwei@chromium.org changed reviewers: + dtapuska@chromium.org
lgtm
https://codereview.chromium.org/2349143004/diff/1/content/browser/renderer_ho... File content/browser/renderer_host/input/web_input_event_builders_mac.mm (right): https://codereview.chromium.org/2349143004/diff/1/content/browser/renderer_ho... content/browser/renderer_host/input/web_input_event_builders_mac.mm:417: result.tiltX = (int) (tilt.x * 90); Can we round instead of truncate? That is what we do on other platforms. https://cs.chromium.org/chromium/src/ui/events/blink/blink_event_util.cc?type...
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2349143004/diff/1/content/browser/renderer_ho... File content/browser/renderer_host/input/web_input_event_builders_mac.mm (right): https://codereview.chromium.org/2349143004/diff/1/content/browser/renderer_ho... content/browser/renderer_host/input/web_input_event_builders_mac.mm:417: result.tiltX = (int) (tilt.x * 90); On 2016/09/20 15:50:50, dtapuska wrote: > Can we round instead of truncate? > > That is what we do on other platforms. > https://cs.chromium.org/chromium/src/ui/events/blink/blink_event_util.cc?type... Acknowledged.
On 2016/09/20 16:12:45, lanwei wrote: > https://codereview.chromium.org/2349143004/diff/1/content/browser/renderer_ho... > File content/browser/renderer_host/input/web_input_event_builders_mac.mm > (right): > > https://codereview.chromium.org/2349143004/diff/1/content/browser/renderer_ho... > content/browser/renderer_host/input/web_input_event_builders_mac.mm:417: > result.tiltX = (int) (tilt.x * 90); > On 2016/09/20 15:50:50, dtapuska wrote: > > Can we round instead of truncate? > > > > That is what we do on other platforms. > > > https://cs.chromium.org/chromium/src/ui/events/blink/blink_event_util.cc?type... > > Acknowledged. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lanwei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org Link to the patchset: https://codereview.chromium.org/2349143004/#ps20001 (title: "Change to lround")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Plumbing stylus tilt for Mac. Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range from -1.0 to 1.0 for both axes, but our values lie in [-90,90]. https://developer.apple.com/reference/appkit/nsevent/1534226-tilt BUG=624814 ========== to ========== Plumbing stylus tilt for Mac. Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range from -1.0 to 1.0 for both axes, but our values lie in [-90,90]. https://developer.apple.com/reference/appkit/nsevent/1534226-tilt BUG=624814 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Plumbing stylus tilt for Mac. Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range from -1.0 to 1.0 for both axes, but our values lie in [-90,90]. https://developer.apple.com/reference/appkit/nsevent/1534226-tilt BUG=624814 ========== to ========== Plumbing stylus tilt for Mac. Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range from -1.0 to 1.0 for both axes, but our values lie in [-90,90]. https://developer.apple.com/reference/appkit/nsevent/1534226-tilt BUG=624814 Committed: https://crrev.com/3c6775ddd60897fd815139b9afe9198c4263dae3 Cr-Commit-Position: refs/heads/master@{#419801} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3c6775ddd60897fd815139b9afe9198c4263dae3 Cr-Commit-Position: refs/heads/master@{#419801} |
