[SVGDom] Only apply opacity when needed

[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but it shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349143002

Committed: https://skia.googlesource.com/skia/+/7cf4ae71220fc2307cf387205fc64dab13ecf7bf

[f(malita), 2016-09-19 01:23:07]

Description was changed from

==========
[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
==========

to

==========
[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349143002
==========

[f(malita), 2016-09-19 01:23:30]

Description was changed from

==========
[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349143002
==========

to

==========
[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but it shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349143002
==========

[f(malita), 2016-09-19 01:24:10]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 01:24:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 01:53:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 01:53:26]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-09-19 12:47:38]

lgtm

https://codereview.chromium.org/2349143002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2349143002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:271: if (opacity &&
opacity->value() < 1) {
// How is the restore conditionally execute, balancing this saveLayer?

[f(malita), 2016-09-19 13:08:30]

https://codereview.chromium.org/2349143002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2349143002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:271: if (opacity &&
opacity->value() < 1) {
On 2016/09/19 12:47:38, reed1 wrote:
> // How is the restore conditionally execute, balancing this saveLayer?

Comment a few lines below:

// Balanced in the destructor, via restoreToCount().

[robertphillips, 2016-09-19 13:40:56]

lgtm

[f(malita), 2016-09-19 13:41:17]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-09-19 13:41:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 13:42:40]

Description was changed from

==========
[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but it shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349143002
==========

to

==========
[SVGDom] Only apply opacity when needed

Opacity: 1 is a no-op, but it shows up quite a bit in existing documents.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349143002

Committed:
https://skia.googlesource.com/skia/+/7cf4ae71220fc2307cf387205fc64dab13ecf7bf
==========

[commit-bot: I haz the power, 2016-09-19 13:42:41]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7cf4ae71220fc2307cf387205fc64dab13ecf7bf