Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.h

Issue 234913005: Refactor wheel event handler registration in ScrollingCoordinator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/scrolling/ScrollingCoordinator.h
diff --git a/Source/core/page/scrolling/ScrollingCoordinator.h b/Source/core/page/scrolling/ScrollingCoordinator.h
index 9ff0f61798534dfee8801901ae03e3b6930b4252..c9e24f89567c5787db2805ce9761f7bd5c5c4009 100644
--- a/Source/core/page/scrolling/ScrollingCoordinator.h
+++ b/Source/core/page/scrolling/ScrollingCoordinator.h
@@ -68,9 +68,11 @@ public:
bool needsToUpdateAfterCompositingChange() const { return m_scrollGestureRegionIsDirty || m_touchEventTargetRectsAreDirty || frameViewIsDirty(); }
- // Should be called whenever a wheel event handler is added or removed in the
- // frame view's underlying document.
- void frameViewWheelEventHandlerCountChanged(FrameView*);
+ // Should be called whenever the presence of wheel event handlers in the page changes.
+ void haveWheelEventHandlersChangedForPage();
+
+ // Should be called whenever the presence of scroll event handlers in the page changes.
+ void haveScrollEventHandlersChangedForPage();
abarth-chromium 2014/04/11 18:53:38 I'd skip these comments. didChangeScrollEventHand
// Should be called whenever the slow repaint objects counter changes between zero and one.
void frameViewHasSlowRepaintObjectsDidChange(FrameView*);
@@ -124,7 +126,6 @@ protected:
bool isForMainFrame(ScrollableArea*) const;
- unsigned computeCurrentWheelEventHandlerCount();
GraphicsLayer* scrollLayerForFrameView(FrameView*);
GraphicsLayer* counterScrollingLayerForFrameView(FrameView*);
@@ -136,7 +137,8 @@ protected:
bool m_shouldScrollOnMainThreadDirty;
private:
- void recomputeWheelEventHandlerCountForFrameView(FrameView*);
+ void updateHaveWheelEventHandlers();
+ void updateHaveScrollEventHandlers();
void setShouldUpdateScrollLayerPositionOnMainThread(MainThreadScrollingReasons);
bool hasVisibleSlowRepaintViewportConstrainedObjects(FrameView*) const;
@@ -145,7 +147,6 @@ private:
void setShouldHandleScrollGestureOnMainThreadRegion(const Region&);
void setTouchEventTargetRects(LayerHitTestRects&);
void computeTouchEventTargetRects(LayerHitTestRects&);
- void setWheelEventHandlerCount(unsigned);
blink::WebScrollbarLayer* addWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation, PassOwnPtr<blink::WebScrollbarLayer>);
blink::WebScrollbarLayer* getWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);

Powered by Google App Engine
This is Rietveld 408576698