Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: net/cert/internal/cert_error_params.cc

Issue 2349103002: Include the RSA key modulus size in error message when it is too small. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/internal/cert_error_params.h" 5 #include "net/cert/internal/cert_error_params.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "net/der/input.h" 9 #include "net/der/input.h"
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 std::string ToDebugString() const override { 59 std::string ToDebugString() const override {
60 return name_ + std::string(": ") + base::SizeTToString(value_); 60 return name_ + std::string(": ") + base::SizeTToString(value_);
61 } 61 }
62 62
63 private: 63 private:
64 const char* name_; 64 const char* name_;
65 size_t value_; 65 size_t value_;
66 }; 66 };
67 67
68 // Parameters subclass for describing (and pretty-printing) two size_t
69 // values.
70 class CertErrorParams2SizeT : public CertErrorParams {
71 public:
72 CertErrorParams2SizeT(const char* name1,
73 size_t value1,
74 const char* name2,
75 size_t value2)
76 : name1_(name1), value1_(value1), name2_(name2), value2_(value2) {}
77
78 std::string ToDebugString() const override {
79 return name1_ + std::string(": ") + base::SizeTToString(value1_) + "\n" +
80 name2_ + std::string(": ") + base::SizeTToString(value2_);
81 }
82
83 private:
84 const char* name1_;
85 size_t value1_;
86 const char* name2_;
87 size_t value2_;
88 };
89
68 } // namespace 90 } // namespace
69 91
70 CertErrorParams::CertErrorParams() = default; 92 CertErrorParams::CertErrorParams() = default;
71 CertErrorParams::~CertErrorParams() = default; 93 CertErrorParams::~CertErrorParams() = default;
72 94
73 std::unique_ptr<CertErrorParams> CreateCertErrorParams1Der( 95 std::unique_ptr<CertErrorParams> CreateCertErrorParams1Der(
74 const char* name1, 96 const char* name,
75 const der::Input& der1) { 97 const der::Input& der) {
76 return base::MakeUnique<CertErrorParams2Der>(name1, der1, nullptr, 98 DCHECK(name);
99 return base::MakeUnique<CertErrorParams2Der>(name, der, nullptr,
77 der::Input()); 100 der::Input());
78 } 101 }
79 102
80 std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der( 103 std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der(
81 const char* name1, 104 const char* name1,
82 const der::Input& der1, 105 const der::Input& der1,
83 const char* name2, 106 const char* name2,
84 const der::Input& der2) { 107 const der::Input& der2) {
108 DCHECK(name1);
109 DCHECK(name2);
85 return base::MakeUnique<CertErrorParams2Der>(name1, der1, name2, der2); 110 return base::MakeUnique<CertErrorParams2Der>(name1, der1, name2, der2);
86 } 111 }
87 112
88 std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT(const char* name, 113 std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT(const char* name,
89 size_t value) { 114 size_t value) {
115 DCHECK(name);
90 return base::MakeUnique<CertErrorParamsSizeT>(name, value); 116 return base::MakeUnique<CertErrorParamsSizeT>(name, value);
91 } 117 }
92 118
119 NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT(
120 const char* name1,
121 size_t value1,
122 const char* name2,
123 size_t value2) {
124 DCHECK(name1);
125 DCHECK(name2);
126 return base::MakeUnique<CertErrorParams2SizeT>(name1, value1, name2, value2);
127 }
128
93 } // namespace net 129 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698