Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 23491002: Revert "This patch implements optimized objectInfo structure which manages the set of observers ass… (Closed)

Created:
7 years, 3 months ago by adamk
Modified:
7 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Revert "This patch implements optimized objectInfo structure which manages the set of observers associated with an object and the changeRecord types which they accept." This reverts r16343 due to mjsunit object-observe failures on several bots: - V8 Linux nosse2 - V8 GC stress 2 TBR=rossberg Committed: https://code.google.com/p/v8/source/detail?r=16344

Patch Set 1 #

Patch Set 2 : Try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -259 lines) Patch
M src/object-observe.js View 13 chunks +157 lines, -255 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
7 years, 3 months ago (2013-08-26 22:43:43 UTC) #1
adamk
Committed patchset #2 manually as r16344.
7 years, 3 months ago (2013-08-26 22:45:16 UTC) #2
adamk
On 2013/08/26 22:45:16, adamk wrote: > Committed patchset #2 manually as r16344. Any hints on ...
7 years, 3 months ago (2013-08-26 22:48:17 UTC) #3
adamk
Tried runnings tests with "--extra-flags --noenable-sse2" which is what the bot seems to do, but ...
7 years, 3 months ago (2013-08-26 23:11:33 UTC) #4
rossberg
7 years, 3 months ago (2013-08-27 09:33:24 UTC) #5
Message was sent while issue was closed.
On 2013/08/26 23:11:33, adamk - vacation until sept 3 wrote:
> Tried runnings tests with
> 
> "--extra-flags --noenable-sse2"
> 
> which is what the bot seems to do, but the test still passes for me.

Running this in the V8 dir seems to reproduce it (thanks to Michael):

./tools/run-tests.py --arch=ia32 --mode=release --extra-flags="--noenable-sse2"
mjsunit/harmony/object-observe

However, it is flaky. You probably have to run it a few times before the failure
occurs.

Unfortunately, I have no idea off-hand concerning the cause.

Powered by Google App Engine
This is Rietveld 408576698