Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: net/cert/internal/verify_certificate_chain.cc

Issue 2349093002: Change the interface for parsing SignatureAlgorithm to take a (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/signature_algorithm_unittest.cc ('k') | net/cert/internal/verify_signed_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_certificate_chain.cc
diff --git a/net/cert/internal/verify_certificate_chain.cc b/net/cert/internal/verify_certificate_chain.cc
index 8c9376bdf2de239f8dabab1edb94917b410edbc0..0abb2ad57f497cdbe578f1393997c81ff62d81c6 100644
--- a/net/cert/internal/verify_certificate_chain.cc
+++ b/net/cert/internal/verify_certificate_chain.cc
@@ -140,7 +140,7 @@ WARN_UNUSED_RESULT bool VerifyTimeValidity(const ParsedCertificate& cert,
WARN_UNUSED_RESULT bool IsRsaWithSha1SignatureAlgorithm(
const der::Input& signature_algorithm_tlv) {
std::unique_ptr<SignatureAlgorithm> algorithm =
- SignatureAlgorithm::CreateFromDer(signature_algorithm_tlv);
+ SignatureAlgorithm::Create(signature_algorithm_tlv, nullptr);
return algorithm &&
algorithm->algorithm() == SignatureAlgorithmId::RsaPkcs1 &&
« no previous file with comments | « net/cert/internal/signature_algorithm_unittest.cc ('k') | net/cert/internal/verify_signed_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698