net/cert/x509_util_openssl.cc - Issue 2349093002: Change the interface for parsing SignatureAlgorithm to take a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_util_openssl.cc

Issue 2349093002: Change the interface for parsing SignatureAlgorithm to take a (Closed)

Patch Set: add comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_util_openssl.cc

diff --git a/net/cert/x509_util_openssl.cc b/net/cert/x509_util_openssl.cc

index 38d1ecbd1101ec27a17808693922c74a6f8d73e3..4c6ee78547ed1fd0b19566cbdae1eff7fc1217db 100644

--- a/net/cert/x509_util_openssl.cc

+++ b/net/cert/x509_util_openssl.cc

@@ -326,7 +326,7 @@ bool GetTLSServerEndPointChannelBinding(const X509Certificate& certificate,

return false;

std::unique_ptr<SignatureAlgorithm> signature_algorithm =

- SignatureAlgorithm::CreateFromDer(signature_algorithm_tlv);

+ SignatureAlgorithm::Create(signature_algorithm_tlv, nullptr);

if (!signature_algorithm)

return false;