net/cert/internal/parsed_certificate.cc - Issue 2349093002: Change the interface for parsing SignatureAlgorithm to take a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/parsed_certificate.cc

Issue 2349093002: Change the interface for parsing SignatureAlgorithm to take a (Closed)

Patch Set: add comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/internal/parsed_certificate.cc

diff --git a/net/cert/internal/parsed_certificate.cc b/net/cert/internal/parsed_certificate.cc

index f2802449134dab4115c55b4ff8e40224d18941fd..6d1a071bce53e0bf04714caebd4d7eb822c2c095 100644

--- a/net/cert/internal/parsed_certificate.cc

+++ b/net/cert/internal/parsed_certificate.cc

@@ -109,7 +109,7 @@ scoped_refptr<ParsedCertificate> ParsedCertificate::CreateInternal(

// TODO(mattm): should distinguish between unsupported algorithms and parsing

// errors.

result->signature_algorithm_ =

- SignatureAlgorithm::CreateFromDer(result->signature_algorithm_tlv_);

+ SignatureAlgorithm::Create(result->signature_algorithm_tlv_, errors);

der::Input subject_value;

if (!GetSequenceValue(result->tbs_.subject_tlv, &subject_value) ||