Change the interface for parsing SignatureAlgorithm to take a

net/cert/internal/verify_signed_data_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/verify_signed_data.h"
 
 #include <memory>
 #include <set>
 
 #include "net/cert/internal/cert_errors.h"
@@ skipping 37 matching lines @@
 
   const PemBlockMapping mappings[] = {
       {"PUBLIC KEY", &public_key},
       {"ALGORITHM", &algorithm},
       {"DATA", &signed_data},
       {"SIGNATURE", &signature_value},
   };
 
   ASSERT_TRUE(ReadTestDataFromPemFile(path, mappings));
 
+  CertErrors algorithm_errors;
   std::unique_ptr<SignatureAlgorithm> signature_algorithm =
-      SignatureAlgorithm::CreateFromDer(der::Input(&algorithm));
-  ASSERT_TRUE(signature_algorithm);
+      SignatureAlgorithm::Create(der::Input(&algorithm), &algorithm_errors);
+  ASSERT_TRUE(signature_algorithm) << algorithm_errors.ToDebugString();
 
   der::BitString signature_value_bit_string;
   der::Parser signature_value_parser((der::Input(&signature_value)));
   ASSERT_TRUE(signature_value_parser.ReadBitString(&signature_value_bit_string))
       << "The signature value is not a valid BIT STRING";
 
   bool expected_result_bool = expected_result == SUCCESS;
 
   // TODO(crbug.com/634443): Verify the returned errors.
-  CertErrors errors;
+  CertErrors verify_errors;
   EXPECT_EQ(expected_result_bool,
             VerifySignedData(*signature_algorithm, der::Input(&signed_data),
                              signature_value_bit_string,
-                             der::Input(&public_key), policy, &errors));
+                             der::Input(&public_key), policy, &verify_errors));
 }
 
 // RunTestCase() is the same as RunTestCaseUsingPolicy(), only it uses a
 // default policy. This policy will accept a basic profile of signature
 // algorithms (including ANY sized RSA key >= 1024).
 void RunTestCase(VerifyResult expected_result, const char* file_name) {
   SimpleSignaturePolicy policy(1024);
   return RunTestCaseUsingPolicy(expected_result, file_name, &policy);
 }
 
@@ skipping 207 matching lines @@
   RunTestCaseUsingPolicy(SUCCESS, "ecdsa-secp384r1-sha256.pem", &policy);
   RunTestCaseUsingPolicy(SUCCESS, "rsa-pkcs1-sha256.pem", &policy);
   RunTestCaseUsingPolicy(SUCCESS, "rsa-pss-sha256-salt10.pem", &policy);
   RunTestCaseUsingPolicy(FAILURE, "rsa-pss-sha256-mgf1-sha512-salt33.pem",
                          &policy);
 }
 
 }  // namespace
 
 }  // namespace net