Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: blimp/client/session/blimp_client_session.cc

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Merge branch 'refs/heads/master' into settings Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/session/blimp_client_session.cc
diff --git a/blimp/client/session/blimp_client_session.cc b/blimp/client/session/blimp_client_session.cc
index 26460d74b58a6a3271bf89df54f6438ce46332cd..36697f8513f5d25ec2ad98ba0123a1f8a879becf 100644
--- a/blimp/client/session/blimp_client_session.cc
+++ b/blimp/client/session/blimp_client_session.cc
@@ -55,7 +55,7 @@ BlimpClientSession::BlimpClientSession(const GURL& assigner_endpoint)
navigation_feature_(new NavigationFeature),
ime_feature_(new ImeFeature),
render_widget_feature_(new RenderWidgetFeature),
- settings_feature_(new SettingsFeature),
+ settings_feature_(new SettingsFeature(nullptr)),
weak_factory_(this) {
base::Thread::Options options;
options.message_loop_type = base::MessageLoop::TYPE_IO;
@@ -154,7 +154,7 @@ void BlimpClientSession::RegisterFeatures() {
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDownloadWholeDocument))
- settings_feature_->SetRecordWholeDocument(true);
+ settings_feature_->OnRecordWholeDocumentChanged(true);
David Trainor- moved to gerrit 2016/10/05 23:46:21 Since we don't really need this method, I'm actual
Menglin 2016/10/06 22:36:38 Done.
}
void BlimpClientSession::DropConnection() {

Powered by Google App Engine
This is Rietveld 408576698