Blimp Settings framework on the c++ side

chrome/browser/prefs/browser_prefs.cc

Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index d6e69ac3bc6e43c59a55a39c77a4b196f799db6b..821379bae91b99989098231c97697f87b2a2f9a1 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -157,8 +157,7 @@
 #endif
 
 #if defined(OS_ANDROID)
-#include "chrome/browser/notifications/notification_platform_bridge_android.h"
-#include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h"
+#include "chrome/browser/android/preferences/browser_android_prefs.h"
 #else
 #include "chrome/browser/services/gcm/gcm_product_util.h"
 #include "chrome/browser/signin/signin_promo.h"
@@ -574,10 +573,7 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   signin::RegisterProfilePrefs(registry);
 #endif
 
-#if defined(OS_ANDROID)
-  NotificationPlatformBridgeAndroid::RegisterProfilePrefs(registry);
-  ntp_snippets::RecentTabSuggestionsProvider::RegisterProfilePrefs(registry);
-#else
+#if !defined(OS_ANDROID)
   browser_sync::ForeignSessionHandler::RegisterProfilePrefs(registry);
   gcm::GCMChannelStatusSyncer::RegisterProfilePrefs(registry);
   gcm::RegisterProfilePrefs(registry);
@@ -677,6 +673,10 @@ void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
 #if defined(OS_CHROMEOS)
   chromeos::PowerPrefs::RegisterUserProfilePrefs(registry);
 #endif
+
+#if defined(OS_ANDROID)
+  ::android::RegisterUserProfilePrefs(registry);

[Lei Zhang, 2016/10/04 01:19:10]

Shouldn't this be RegisterProfilePrefs() and shouldn't it be called around like
576?

[Menglin, 2016/10/04 01:21:46]

Oh thought doing something similar to the
chromeos::PowerPrefs::RegisterUserProfilePrefs(registry); at line 674

[Lei Zhang, 2016/10/04 01:33:56]

Ah, ok.

+#endif
 }
 
 void RegisterScreenshotPrefs(PrefRegistrySimple* registry) {