Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3158)

Unified Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Settings doesn't own its observer anymore. SettingsFeature subclass SettingsObserver Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/blimp_client_context_impl.h
diff --git a/blimp/client/core/blimp_client_context_impl.h b/blimp/client/core/blimp_client_context_impl.h
index dee8bd6a5161c34337de1b95c8ad99f55f4c5ed0..00eaf7a873776c226ec930cf8ef40bdb086e9107 100644
--- a/blimp/client/core/blimp_client_context_impl.h
+++ b/blimp/client/core/blimp_client_context_impl.h
@@ -37,6 +37,7 @@ class ImeFeature;
class NavigationFeature;
class RenderWidgetFeature;
class SettingsFeature;
+class Settings;
class TabControlFeature;
// BlimpClientContextImpl is the implementation of the main context-class for
@@ -53,7 +54,8 @@ class BlimpClientContextImpl
BlimpClientContextImpl(
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner,
- std::unique_ptr<CompositorDependencies> compositor_dependencies);
+ std::unique_ptr<CompositorDependencies> compositor_dependencies,
+ PrefService* local_state);
~BlimpClientContextImpl() override;
// BlimpClientContext implementation.
@@ -115,6 +117,9 @@ class BlimpClientContextImpl
// A set of dependencies required by all BlimpCompositor instances.
std::unique_ptr<BlimpCompositorDependencies> blimp_compositor_dependencies_;
+ // Through this settings are set and retrieved.
+ std::unique_ptr<Settings> settings_;
+
// Features to handle all incoming and outgoing protobuf messages.
std::unique_ptr<BlobChannelFeature> blob_channel_feature_;
std::unique_ptr<GeolocationFeature> geolocation_feature_;

Powered by Google App Engine
This is Rietveld 408576698