blimp/client/core/android/blimp_client_context_impl_android.h - Issue 2349073002: Blimp Settings framework on the c++ side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/blimp_client_context_impl_android.h

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)

Patch Set: Settings doesn't own its observer anymore. SettingsFeature subclass SettingsObserver Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/android/blimp_client_context_impl_android.h

diff --git a/blimp/client/core/android/blimp_client_context_impl_android.h b/blimp/client/core/android/blimp_client_context_impl_android.h

index d7d6a406027d6ec106eb160354dc3cf22f4cee7f..278650d1496c297a987f378317f2ecaaa61d355c 100644

--- a/blimp/client/core/android/blimp_client_context_impl_android.h

+++ b/blimp/client/core/android/blimp_client_context_impl_android.h

@@ -30,7 +30,8 @@ class BlimpClientContextImplAndroid : public BlimpClientContextImpl {

explicit BlimpClientContextImplAndroid(

scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner,

scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner,

- std::unique_ptr<CompositorDependencies> compositor_dependencies);

+ std::unique_ptr<CompositorDependencies> compositor_dependencies,

+ PrefService* local_state);

~BlimpClientContextImplAndroid() override;

base::android::ScopedJavaLocalRef<jobject> GetJavaObject();