blimp/client/core/BUILD.gn - Issue 2349073002: Blimp Settings framework on the c++ side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/BUILD.gn

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)

Patch Set: Settings doesn't own its observer anymore. SettingsFeature subclass SettingsObserver Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/BUILD.gn

diff --git a/blimp/client/core/BUILD.gn b/blimp/client/core/BUILD.gn

index 121de4fdccbd4ac333f10de3ec245c1fdeb931f4..de102083ce9e69e7f2107274bd9b0ea7b0a333ef 100644

--- a/blimp/client/core/BUILD.gn

+++ b/blimp/client/core/BUILD.gn

@@ -85,6 +85,7 @@ source_set("unit_tests") {

"//blimp/client/core/geolocation:unit_tests",

"//blimp/client/core/render_widget:unit_tests",

"//blimp/client/core/session:unit_tests",

+ "//blimp/client/core/settings:unit_tests",

"//blimp/client/public:public_headers",

"//blimp/client/test",

"//testing/gmock",

« no previous file with comments | « no previous file | blimp/client/core/DEPS » ('j') | blimp/client/core/blimp_client_context_impl.cc » ('J')