Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: blimp/client/core/settings/BUILD.gn

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/settings/BUILD.gn
diff --git a/blimp/client/core/settings/BUILD.gn b/blimp/client/core/settings/BUILD.gn
index 0cf9ca57c7368046f37efe85a83cc2b304f457dd..6045d0904a355227d651060c3023a27a0bc34928 100644
--- a/blimp/client/core/settings/BUILD.gn
+++ b/blimp/client/core/settings/BUILD.gn
@@ -12,12 +12,21 @@ source_set("settings") {
sources = [
"blimp_settings_delegate.h",
+ "record_whole_document_observer.cc",
+ "record_whole_document_observer.h",
+ "settings.cc",
+ "settings.h",
"settings_feature.cc",
"settings_feature.h",
+ "settings_observer.h",
+ "settings_prefs.cc",
+ "settings_prefs.h",
]
deps = [
+ "//blimp/client/core:switches",
"//blimp/common",
+ "//components/prefs",
"//net",
]
@@ -40,6 +49,24 @@ source_set("settings") {
}
}
+source_set("unit_tests") {
+ visibility = [ "//blimp/client/core:unit_tests" ]
+
+ testonly = true
+
+ sources = [
+ "settings_unittest.cc",
+ ]
+
+ deps = [
+ ":settings",
+ "//base",
+ "//components/prefs:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
+}
+
if (is_android) {
android_library("settings_java") {
visibility = [ "//blimp/client/*" ]

Powered by Google App Engine
This is Rietveld 408576698