chrome/browser/DEPS - Issue 2349073002: Blimp Settings framework on the c++ side

Side by Side Diff: chrome/browser/DEPS

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)

Patch Set: Settings doesn't own its observer anymore. SettingsFeature subclass SettingsObserver Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« blimp/client/core/settings/settings_observer.h ('K') | « blimp/engine/browser_tests/integration_test.cc ('k') | chrome/browser/android/blimp/blimp_client_context_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+apps",	2 "+apps",

3 "+ash",	3 "+ash",

	4 "+blimp/client/public",
	Lei Zhang 2016/09/30 23:55:35 If the Android-only portion of chrome::RegisterLoc If the Android-only portion of chrome::RegisterLocalState() moved into chrome/browser/android, do you think this can be omitted, since chrome/browser/android/DEPS already has this rule? i.e. Do for foresee any other part of chrome/browser outside of chrome/browser/android that will need to access blimp/client/public? Menglin 2016/10/01 00:08:31 I know you meant RegisterProfilePrefs() :) For no Show quoted text On 2016/09/30 23:55:35, Lei Zhang wrote: > If the Android-only portion of chrome::RegisterLocalState() moved into > chrome/browser/android, do you think this can be omitted, since > chrome/browser/android/DEPS already has this rule? > > i.e. Do for foresee any other part of chrome/browser outside of > chrome/browser/android that will need to access blimp/client/public? I know you meant RegisterProfilePrefs() :) For now I can't think of any other part of chrome/browser needs access to blimp/client/public. David, wdyt? David Trainor- moved to gerrit 2016/10/01 03:26:35 I'm fine with relying on the DEPS from chrome/brow Show quoted text On 2016/10/01 00:08:31, Menglin wrote: > On 2016/09/30 23:55:35, Lei Zhang wrote: > > If the Android-only portion of chrome::RegisterLocalState() moved into > > chrome/browser/android, do you think this can be omitted, since > > chrome/browser/android/DEPS already has this rule? > > > > i.e. Do for foresee any other part of chrome/browser outside of > > chrome/browser/android that will need to access blimp/client/public? > > I know you meant RegisterProfilePrefs() :) > > For now I can't think of any other part of chrome/browser needs access to > blimp/client/public. David, wdyt? I'm fine with relying on the DEPS from chrome/browser/android :). If we really need to access blimp/client/public in chrome/browser in the future we can add a DEPS then. Lei Zhang 2016/10/03 23:13:54 So do we want to refactor the Android-only portion Show quoted text On 2016/10/01 03:26:35, David Trainor wrote: > I'm fine with relying on the DEPS from chrome/browser/android :). If we really > need to access blimp/client/public in chrome/browser in the future we can add a > DEPS then. So do we want to refactor the Android-only portion of RegisterLocalState() and RegisterProfilePrefs() into, say, chrome/browser/android/preferences/browser_prefs.cc?
4 "+chrome/app",	5 "+chrome/app",

5 "+chrome/chrome_watcher",	6 "+chrome/chrome_watcher",

6 "+chrome/grit",	7 "+chrome/grit",

7 "+chrome/install_static",	8 "+chrome/install_static",

8 "+chrome/installer",	9 "+chrome/installer",

9 "+chrome_elf/blacklist",	10 "+chrome_elf/blacklist",

10 "+chrome_elf/chrome_elf_constants.h",	11 "+chrome_elf/chrome_elf_constants.h",

11 "+chrome_elf/dll_hash",	12 "+chrome_elf/dll_hash",

12 "+chromeos",	13 "+chromeos",

13 "+components",	14 "+components",

(...skipping 85 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 "+third_party/WebKit/public/platform/modules/webshare/webshare.mojom.h",	100 "+third_party/WebKit/public/platform/modules/webshare/webshare.mojom.h",

100 "+third_party/WebKit/public/web/WebCache.h",	101 "+third_party/WebKit/public/web/WebCache.h",

101 "+third_party/WebKit/public/web/WebContextMenuData.h",	102 "+third_party/WebKit/public/web/WebContextMenuData.h",

102 "+third_party/WebKit/public/web/WebFindOptions.h",	103 "+third_party/WebKit/public/web/WebFindOptions.h",

103 "+third_party/WebKit/public/web/WebInputEvent.h",	104 "+third_party/WebKit/public/web/WebInputEvent.h",

104 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",	105 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",

105 "+third_party/WebKit/public/web/WebPluginAction.h",	106 "+third_party/WebKit/public/web/WebPluginAction.h",

106 "+third_party/WebKit/public/web/WebTextDirection.h",	107 "+third_party/WebKit/public/web/WebTextDirection.h",

107 "+third_party/WebKit/public/web/WebWindowFeatures.h",	108 "+third_party/WebKit/public/web/WebWindowFeatures.h",

108 ]	109 ]

OLD	NEW