blimp/client/core/settings/settings_observer.cc - Issue 2349073002: Blimp Settings framework on the c++ side

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/core/settings/settings_observer.cc

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)

Patch Set: Settings doesn't own its observer anymore. SettingsFeature subclass SettingsObserver Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "blimp/client/core/settings/settings_observer.h"

	6

	7 #include "blimp/client/core/settings/settings.h"

	8

	9 namespace blimp {

	10 namespace client {

	11

	12 SettingsObserver::SettingsObserver(Settings* settings) : settings_(settings) {

	13 if(settings_) {

	14 settings_->AddObserver(this);

	15 }

	16 }

	17

	18 SettingsObserver::~SettingsObserver() {

	19 if (settings_) {

	20 settings_->RemoveObserver(this);

	21 }

	22 }

	23

	24 } // namespace client

	25 } // namespace blimp

OLD	NEW