Blimp Settings framework on the c++ side

blimp/client/core/settings/settings_feature.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/settings/settings_feature.h"
 
+#include "blimp/client/core/settings/settings.h"
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/common/proto/settings.pb.h"
 #include "net/base/net_errors.h"
 
 namespace blimp {
 namespace client {
 
-SettingsFeature::SettingsFeature() : record_whole_document_(false) {}
+SettingsFeature::SettingsFeature(Settings* settings)
+    : SettingsObserver(settings) {}
 
-SettingsFeature::~SettingsFeature() {}
+SettingsFeature::~SettingsFeature() = default;
 
 void SettingsFeature::set_outgoing_message_processor(
     std::unique_ptr<BlimpMessageProcessor> processor) {
   outgoing_message_processor_ = std::move(processor);
 }
 
-void SettingsFeature::SetRecordWholeDocument(bool record_whole_document) {
-  if (record_whole_document_ == record_whole_document)
-    return;
-
-  record_whole_document_ = record_whole_document;
-
+void SettingsFeature::OnRecordWholeDocumentChanged(bool enable) {
   EngineSettingsMessage* engine_settings;
   std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&engine_settings);
-  engine_settings->set_record_whole_document(record_whole_document_);
+  engine_settings->set_record_whole_document(enable);
   outgoing_message_processor_->ProcessMessage(std::move(message),
                                               net::CompletionCallback());
 }
 
 void SettingsFeature::SendUserAgentOSVersionInfo(const std::string& osVersion) {

[David Trainor- moved to gerrit, 2016/10/01 03:26:34]

Oops we never call this!  See crbug.com/652032 that I just filed to track it.

   EngineSettingsMessage* engine_settings;
   std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&engine_settings);
   engine_settings->set_client_os_info(osVersion);
   outgoing_message_processor_->ProcessMessage(std::move(message),
                                               net::CompletionCallback());
 }
 
 void SettingsFeature::ProcessMessage(std::unique_ptr<BlimpMessage> message,
                                      const net::CompletionCallback& callback) {
   // We don't receive any messages from the engine yet.
   NOTREACHED() << "Invalid settings message received from the engine.";
   callback.Run(net::OK);
 }
 
+void SettingsFeature::PushSettings() {
+  OnRecordWholeDocumentChanged(settings()->record_whole_document());

[David Trainor- moved to gerrit, 2016/10/01 03:26:35]

Can we just build one big EngineSettingsMessage and set all the values on the
proto that we need?  I think we can set more than one value on the
EngineSettingsMessage at once.

[Menglin, 2016/10/03 23:08:27]

Done.

+}
+
 }  // namespace client
 }  // namespace blimp