Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: blimp/client/core/settings/BUILD.gn

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Settings doesn't own its observer anymore. SettingsFeature subclass SettingsObserver Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 source_set("settings") { 10 source_set("settings") {
11 visibility = [ "//blimp/client/*" ] 11 visibility = [ "//blimp/client/*" ]
12 12
13 sources = [ 13 sources = [
14 "blimp_settings_delegate.h", 14 "blimp_settings_delegate.h",
15 "settings.cc",
16 "settings.h",
15 "settings_feature.cc", 17 "settings_feature.cc",
16 "settings_feature.h", 18 "settings_feature.h",
19 "settings_observer.cc",
20 "settings_observer.h",
21 "settings_prefs.cc",
22 "settings_prefs.h",
17 ] 23 ]
18 24
19 deps = [ 25 deps = [
26 "//blimp/client/core:switches",
20 "//blimp/common", 27 "//blimp/common",
28 "//components/prefs",
21 "//net", 29 "//net",
22 ] 30 ]
23 31
24 public_deps = [ 32 public_deps = [
25 "//base", 33 "//base",
26 "//blimp/net", 34 "//blimp/net",
27 ] 35 ]
28 36
29 if (is_android) { 37 if (is_android) {
30 sources += [ 38 sources += [
31 "android/blimp_settings_android.cc", 39 "android/blimp_settings_android.cc",
32 "android/blimp_settings_android.h", 40 "android/blimp_settings_android.h",
33 ] 41 ]
34 42
35 deps += [ 43 deps += [
36 ":settings_jni_headers", 44 ":settings_jni_headers",
37 "//blimp/client/core/session", 45 "//blimp/client/core/session",
38 "//blimp/common", 46 "//blimp/common",
39 ] 47 ]
40 } 48 }
41 } 49 }
42 50
51 source_set("unit_tests") {
52 visibility = [ "//blimp/client/core:unit_tests" ]
53
54 testonly = true
55
56 sources = [
57 "settings_unittest.cc",
58 ]
59
60 deps = [
61 ":settings",
62 "//base",
63 "//components/prefs:test_support",
64 "//testing/gmock",
65 "//testing/gtest",
66 ]
67 }
68
43 if (is_android) { 69 if (is_android) {
44 android_library("settings_java") { 70 android_library("settings_java") {
45 visibility = [ "//blimp/client/*" ] 71 visibility = [ "//blimp/client/*" ]
46 72
47 java_files = [ 73 java_files = [
48 "../android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreference s.java", 74 "../android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreference s.java",
49 "../android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDele gate.java", 75 "../android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDele gate.java",
50 ] 76 ]
51 77
52 # TODO(xingliu): Clean resources files in the future. http://crbug.com/63068 7. 78 # TODO(xingliu): Clean resources files in the future. http://crbug.com/63068 7.
(...skipping 11 matching lines...) Expand all
64 generate_jni("settings_jni_headers") { 90 generate_jni("settings_jni_headers") {
65 visibility = [ ":*" ] 91 visibility = [ ":*" ]
66 92
67 sources = [ 93 sources = [
68 "../android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreference s.java", 94 "../android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreference s.java",
69 ] 95 ]
70 96
71 jni_package = "blimp/client/core/settings" 97 jni_package = "blimp/client/core/settings"
72 } 98 }
73 } 99 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698