Blimp Settings framework on the c++ side

blimp/client/app/linux/blimp_main.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/threading/thread.h"
@@ skipping 29 matching lines @@
 
   // Creating this using "new" and passing to context using "WrapUnique" as
   // opposed to "MakeUnique" because we'll need to pass the compositor
   // dependencies to the display manager as well.
   blimp::client::CompositorDependencies* compositor_dependencies =
       new blimp::client::CompositorDependenciesImpl();
   // Creating the context delegate before the context so that the context is
   // destroyed before the delegate.
   std::unique_ptr<blimp::client::BlimpClientContextDelegate> context_delegate =
       base::MakeUnique<blimp::client::BlimpClientContextDelegateLinux>();
   std::unique_ptr<blimp::client::BlimpClientContext> context =

[Bernhard Bauer, 2016/10/25 14:30:50]

FWIW, I would consider using auto here, as you already spell out the type on the
next line, and it might help reducing the Tower Of Indentation here.

[Menglin, 2016/10/25 18:32:52]

Done.

       base::WrapUnique<blimp::client::BlimpClientContext>(
           blimp::client::BlimpClientContext::Create(
               io_thread.task_runner(), io_thread.task_runner(),
-              base::WrapUnique(compositor_dependencies)));
+              base::WrapUnique(compositor_dependencies),
+              static_cast<blimp::client::BlimpClientContextDelegateLinux*>
+              (context_delegate.get())->pref_service()));

[Bernhard Bauer, 2016/10/25 14:30:50]

Is this indented correctly?

[Menglin, 2016/10/25 18:32:52]

Done.

   context->SetDelegate(context_delegate.get());
 
   context->Connect();
 
   // If there is a non-switch argument to the command line, load that url.
   base::CommandLine::StringVector args =
       base::CommandLine::ForCurrentProcess()->GetArgs();
   std::string url = args.size() > 0 ? args[0] : kDefaultUrl;
   std::unique_ptr<blimp::client::BlimpContents> contents =
       context->CreateBlimpContents(nullptr);
   contents->GetNavigationController().LoadURL(GURL(url));
 
   std::unique_ptr<blimp::client::BlimpDisplayManagerDelegate>
       display_manager_delegate =
           base::MakeUnique<blimp::client::BlimpDisplayManagerDelegateMain>();
   blimp::client::BlimpDisplayManager display_manager(
       display_manager_delegate.get(), compositor_dependencies);
   display_manager.SetWindowSize(gfx::Size(kWindowWidth, kWindowHeight));
   display_manager.SetBlimpContents(std::move(contents));
 
   base::RunLoop().Run();
 }