Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: blimp/client/core/settings/settings_feature.h

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Remove OnRecordWholeDocumentChanged from SettingsObserver and SettingsFeature Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_FEATURE_H_ 5 #ifndef BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_FEATURE_H_
6 #define BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_FEATURE_H_ 6 #define BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_FEATURE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "blimp/net/blimp_message_processor.h" 9 #include "blimp/net/blimp_message_processor.h"
10 10
11 namespace blimp { 11 namespace blimp {
12 namespace client { 12 namespace client {
13 13
14 class Settings;
15
14 // The feature is used to send global settings to the engine. 16 // The feature is used to send global settings to the engine.
15 class SettingsFeature : public BlimpMessageProcessor { 17 class SettingsFeature : public BlimpMessageProcessor {
16 public: 18 public:
17 SettingsFeature(); 19 // Caller ensures |settings| outlives this object.
20 explicit SettingsFeature(Settings* settings);
18 ~SettingsFeature() override; 21 ~SettingsFeature() override;
19 22
20 // Set the BlimpMessageProcessor that will be used to send 23 // Set the BlimpMessageProcessor that will be used to send
21 // BlimpMessage::SETTINGS messages to the engine. 24 // BlimpMessage::SETTINGS messages to the engine.
22 void set_outgoing_message_processor( 25 void set_outgoing_message_processor(
23 std::unique_ptr<BlimpMessageProcessor> processor); 26 std::unique_ptr<BlimpMessageProcessor> processor);
24 27
25 void SetRecordWholeDocument(bool record_whole_document);
26 void SendUserAgentOSVersionInfo(const std::string& client_os_info); 28 void SendUserAgentOSVersionInfo(const std::string& client_os_info);
27 29
28 // BlimpMessageProcessor implementation. 30 // BlimpMessageProcessor implementation.
29 void ProcessMessage(std::unique_ptr<BlimpMessage> message, 31 void ProcessMessage(std::unique_ptr<BlimpMessage> message,
30 const net::CompletionCallback& callback) override; 32 const net::CompletionCallback& callback) override;
31 33
34 // Send the necessary settings to the engine.
35 void PushSettings();
36
32 private: 37 private:
33 // Used to send BlimpMessage::TAB_CONTROL messages to the engine. 38 // Used to send BlimpMessage::TAB_CONTROL messages to the engine.
34 std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_; 39 std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_;
35 40
36 // Used to avoid sending unnecessary messages to engine. 41 Settings* settings_;
37 bool record_whole_document_;
38 42
39 DISALLOW_COPY_AND_ASSIGN(SettingsFeature); 43 DISALLOW_COPY_AND_ASSIGN(SettingsFeature);
40 }; 44 };
41 45
42 } // namespace client 46 } // namespace client
43 } // namespace blimp 47 } // namespace blimp
44 48
45 #endif // BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_FEATURE_H_ 49 #endif // BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_FEATURE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698