Issue 2349063002: Using the correct WebTestDelegate from WebFrameTestClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2349063002: Using the correct WebTestDelegate from WebFrameTestClient.

Created:
4 years, 3 months ago by Łukasz Anforowicz

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, einbinder+watch-test-runner_chromium.org, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Using the correct WebTestDelegate from WebFrameTestClient. Before this CL, WebFrameTestClient would use a global delegate passed to it at construction time. This led to UaF issues, because this delegate could live shorter than the WebFrameTestClient. The right delegate is the one associated with WebViewTestProxyBase (because WebView and WebViewTestProxyBase will live at least as long as WebFrame and WebFrameTestClient). BUG=646607, 606594

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -84 lines)			Patch
M	components/test_runner/web_frame_test_client.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/test_runner/web_frame_test_client.cc	View	19 chunks	+79 lines, -78 lines	0 comments	Download
M	components/test_runner/web_test_interfaces.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/FlagExpectations/site-per-process	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 1814963002 Patch 90001