Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2349043002: android: Remove unused GetScrollFriction (Closed)

Created:
4 years, 3 months ago by boliu
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove unused GetScrollFriction BUG=625089 Committed: https://crrev.com/247beb903300d6716c9ecd693597906551dd2d0b Cr-Commit-Position: refs/heads/master@{#419347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gfx/android/view_configuration.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/gfx/android/view_configuration.cc View 5 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
boliu
ptal fwiw ViewConfiguration has a lot of the same problem as DeviceDisplayInfo, I'll try to ...
4 years, 3 months ago (2016-09-16 23:22:50 UTC) #2
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-17 00:25:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349043002/1
4 years, 3 months ago (2016-09-17 00:26:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 00:31:21 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:41:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/247beb903300d6716c9ecd693597906551dd2d0b
Cr-Commit-Position: refs/heads/master@{#419347}

Powered by Google App Engine
This is Rietveld 408576698