Issue 234903003: Should throw TypeError instead of TypeMismatchError (canvas)

Issue 234903003: Should throw TypeError instead of TypeMismatchError (canvas) (Closed)

Created:
6 years, 8 months ago by zino

Modified:
6 years, 8 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Should throw TypeError instead of TypeMismatchError (canvas) TypeMismatchError is already deprecated. We should throw TypeError instead of TypeMismatchError when the given argument is mismatched. This CL affects (Source/core/html/*) and some layout tests. This aligns behavior with WebIDL, Gecko and Trident. Additional Information: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19898 https://www.w3.org/Bugs/Public/show_bug.cgi?id=19921 https://bugs.webkit.org/show_bug.cgi?id=101604 BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171351

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -41 lines)			Patch
M	LayoutTests/canvas/philip/tests/2d.drawImage.null.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/canvas/philip/tests/2d.imageData.put.null.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/canvas/philip/tests/2d.pattern.image.null.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/canvas/canvas-isPointInStroke-with-path-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/canvas-path-addpath-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/canvas/canvas-path-context-clip-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/canvas/canvas-path-context-fill-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/canvas/canvas-path-context-stroke-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/canvas-scroll-path-into-view-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/drawImage-with-broken-image-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-clip-expected.txt	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-fill-expected.txt	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-stroke-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/core/html/canvas/Path2D.h	View		1 chunk	+1 line, -1 line	0 comments	Download