Remove assumption from the heap verifier that objects occupy a narrow range of the address space.

Remove assumption from the heap verifier that objects occupy a narrow range of the address space.

Fixes #27373.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ecc880ffcf1268aebabc772692aa0562b401043

[rmacnak, 2016-09-16 22:13:57]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2016-09-16 22:30:22]

lgtm w/ question.

Thanks!

https://codereview.chromium.org/2349023002/diff/40001/runtime/vm/object_set.h
File runtime/vm/object_set.h (right):

https://codereview.chromium.org/2349023002/diff/40001/runtime/vm/object_set.h...
runtime/vm/object_set.h:64: for (ObjectSetRegion* region = head_;
How slow is this? I guess we'll have to monitor the bots for extra timeouts, and
replace the list with a hashtable keyed by the high bits of the start address of
the regions or something like that.

[rmacnak, 2016-09-16 22:39:50]

https://codereview.chromium.org/2349023002/diff/40001/runtime/vm/object_set.h
File runtime/vm/object_set.h (right):

https://codereview.chromium.org/2349023002/diff/40001/runtime/vm/object_set.h...
runtime/vm/object_set.h:64: for (ObjectSetRegion* region = head_;
On 2016/09/16 22:30:22, zra wrote:
> How slow is this? I guess we'll have to monitor the bots for extra timeouts,
and
> replace the list with a hashtable keyed by the high bits of the start address
of
> the regions or something like that.

I didn't see timeouts locally with another workspace compiling in the
background, but the bots might be slower still.

[rmacnak, 2016-09-16 22:41:51]

Description was changed from

==========
Remove assumption from the heap verifier that objects occupy a narrow range of
the address space.

Fixes #27373.
==========

to

==========
Remove assumption from the heap verifier that objects occupy a narrow range of
the address space.

Fixes #27373.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5ecc880ffcf1268aebabc772692aa0562b401043
==========

[rmacnak, 2016-09-16 22:41:52]

Committed patchset #3 (id:40001) manually as
5ecc880ffcf1268aebabc772692aa0562b401043 (presubmit successful).