Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2349013002: crashpad/continuous: Use bot_update. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -1025 lines) Patch
M scripts/slave/recipes/crashpad/continuous.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel.json View 2 chunks +25 lines, -64 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel_clobber.json View 2 chunks +25 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dnj
PTAL. This should be fine unless there is some nuance I'm not seeing in the ...
4 years, 3 months ago (2016-09-16 21:34:08 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 21:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349013002/1
4 years, 3 months ago (2016-09-16 21:39:07 UTC) #6
scottmg
Thanks!
4 years, 3 months ago (2016-09-16 21:39:31 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 21:43:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e549894cc4f86f3f2107...

Powered by Google App Engine
This is Rietveld 408576698