Makes WindowTree::DeleteWindow() unembed for roots

Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3
Cr-Commit-Position: refs/heads/master@{#419401}

[sky, 2016-09-16 20:45:03]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:45:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-16 20:45:44]

Description was changed from

==========
Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org
==========

[sky, 2016-09-16 20:45:44]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[sky, 2016-09-16 20:46:02]

+tsepez for mojom changes (which is just documenting new behavior).

[Tom Sepez, 2016-09-16 20:54:30]

Comments LGTM with nit.

https://codereview.chromium.org/2349003002/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/2349003002/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/window_tree.mojom:70: // root the client no longer
has access to the embed root. The embedder of
nit: root,

[sky, 2016-09-16 21:07:53]

https://codereview.chromium.org/2349003002/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/2349003002/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/window_tree.mojom:70: // root the client no longer
has access to the embed root. The embedder of
On 2016/09/16 20:54:29, Tom Sepez wrote:
> nit: root, 

Done.

[sky, 2016-09-16 21:08:01]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 21:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:10:38]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-16 23:49:17]

lgtm

https://codereview.chromium.org/2349003002/diff/40001/services/ui/ws/window_t...
File services/ui/ws/window_tree.cc (right):

https://codereview.chromium.org/2349003002/diff/40001/services/ui/ws/window_t...
services/ui/ws/window_tree.cc:916: // Notify the owner of the window it no
longer has an a client embedded in
s/an//

[sky, 2016-09-18 15:40:07]

https://codereview.chromium.org/2349003002/diff/40001/services/ui/ws/window_t...
File services/ui/ws/window_tree.cc (right):

https://codereview.chromium.org/2349003002/diff/40001/services/ui/ws/window_t...
services/ui/ws/window_tree.cc:916: // Notify the owner of the window it no
longer has an a client embedded in
On 2016/09/16 23:49:17, sadrul wrote:
> s/an//

Done.

[sky, 2016-09-18 15:40:10]

The CQ bit was checked by sky@chromium.org

[sky, 2016-09-18 15:40:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2349003002/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2016-09-18 15:40:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 17:27:40]

Description was changed from

==========
Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org
==========

[commit-bot: I haz the power, 2016-09-18 17:27:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-18 17:29:05]

Description was changed from

==========
Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Makes WindowTree::DeleteWindow() unembed for roots

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3
Cr-Commit-Position: refs/heads/master@{#419401}
==========

[commit-bot: I haz the power, 2016-09-18 17:29:06]

Patchset 4 (id:??) landed as
https://crrev.com/bb1b5cd67a3b5459cde2950c037776f88f9776e3
Cr-Commit-Position: refs/heads/master@{#419401}