Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Issue 23490022: Reland "Fix missing x87 tracking for deferred code." (Closed)

Created:
7 years, 3 months ago by oliv
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reland "Fix missing x87 tracking for deferred code." Fixed mac build. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -46 lines) Patch
M src/ia32/lithium-codegen-ia32.h View 6 chunks +16 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 30 chunks +76 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
the diff to the previous cl is ia32/lithium-codegen-ia32.cc:426, used to be x87_stack_ = X87Stack(code->x87_stack()); which ...
7 years, 3 months ago (2013-08-30 09:54:41 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 3 months ago (2013-08-30 09:56:36 UTC) #2
oliv
7 years, 3 months ago (2013-08-30 11:58:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16449 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698