Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: pkg/barback/lib/src/phase.dart

Issue 23490011: Fix a few warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase_input.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library barback.phase; 5 library barback.phase;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:collection'; 8 import 'dart:collection';
9 9
10 import 'asset_cascade.dart'; 10 import 'asset_cascade.dart';
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 /// This will remove all the phase's outputs and all following phases. 158 /// This will remove all the phase's outputs and all following phases.
159 void remove() { 159 void remove() {
160 removeFollowing(); 160 removeFollowing();
161 for (var input in _inputs.values.toList()) { 161 for (var input in _inputs.values.toList()) {
162 input.remove(); 162 input.remove();
163 } 163 }
164 _onDirtyPool.close(); 164 _onDirtyPool.close();
165 } 165 }
166 166
167 /// Remove all phases after this one. 167 /// Remove all phases after this one.
168 Phase removeFollowing() { 168 void removeFollowing() {
169 if (_next == null) return; 169 if (_next == null) return;
170 _next.remove(); 170 _next.remove();
171 _next = null; 171 _next = null;
172 } 172 }
173 173
174 /// Processes this phase. 174 /// Processes this phase.
175 /// 175 ///
176 /// Returns a future that completes when processing is done. If there is 176 /// Returns a future that completes when processing is done. If there is
177 /// nothing to process, returns `null`. 177 /// nothing to process, returns `null`.
178 Future process() { 178 Future process() {
(...skipping 22 matching lines...) Expand all
201 for (var id in outputIds) { 201 for (var id in outputIds) {
202 // It's possible the output was removed before other transforms in this 202 // It's possible the output was removed before other transforms in this
203 // phase finished. 203 // phase finished.
204 if (!_outputs.containsKey(id)) continue; 204 if (!_outputs.containsKey(id)) continue;
205 var exception = _outputs[id].collisionException; 205 var exception = _outputs[id].collisionException;
206 if (exception != null) cascade.reportError(exception); 206 if (exception != null) cascade.reportError(exception);
207 } 207 }
208 }); 208 });
209 } 209 }
210 } 210 }
OLDNEW
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase_input.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698